Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ExtEvSimulationClasses #898

Open
sebastian-peter opened this issue Aug 12, 2024 · 0 comments · May be fixed by #985
Open

Update ExtEvSimulationClasses #898

sebastian-peter opened this issue Aug 12, 2024 · 0 comments · May be fixed by #985
Assignees
@marvinheintze
Labels
documentation Improvements or additions to documentation HiWiStart Good for New HiWis

Comments

@sebastian-peter
Copy link
Member

The diagram is outdated, especially related to the data messages (EvDataMessageFromExt and EvDataResponseMessageToExt). Please also check if there's more out-of-date classes there.

When I created the class diagram, I used lots of hidden place holders to layout the thing. (The current version of PlantUML has a bug that displays the place holder classes, use version 1.2023.10 for this to properly work).
Since arranging classes with these place holders can be quite annoying, either:

  1. deal with it and adapt the place holders so that the diagram structure somewhat stays the same
  2. find a better way to layout this without place holders

The visual separation of the diagram in control flow (ExtSimAdapter etc. on the left side) and data flow (ExtEvData etc. on the right side) should remain.
@sebastian-peter sebastian-peter added the documentation Improvements or additions to documentation label Aug 12, 2024
@sebastian-peter sebastian-peter mentioned this issue Aug 12, 2024
Merged
@sebastian-peter sebastian-peter added the HiWiStart Good for New HiWis label Aug 13, 2024
@marvinheintze marvinheintze self-assigned this Aug 19, 2024
@sebastian-peter sebastian-peter mentioned this issue Aug 29, 2024
Merged
marvinheintze added a commit that referenced this issue Oct 7, 2024
@marvinheintze
Merge branch 'dev' into mh/#898-updating-diagram
eeee724 
# Conflicts:
#	CHANGELOG.md
#	docs/uml/main/ExtEvSimulationClasses.puml
@marvinheintze marvinheintze linked a pull request Oct 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinheintze marvinheintze

Labels
documentation Improvements or additions to documentation HiWiStart Good for New HiWis
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mh/#898 updating diagram ie3-institute/simona
2 participants
@sebastian-peter @marvinheintze