Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable init for primary data and result data #168

Open
wants to merge 53 commits into
base: dev
Choose a base branch
from
Open

Enable init for primary data and result data #168

wants to merge 53 commits into from

Conversation

jo-bao
Copy link
Contributor

@jo-bao jo-bao commented Mar 16, 2024 •
edited
Loading

Resolves #167

@jo-bao jo-bao self-assigned this Mar 16, 2024
@jo-bao jo-bao mentioned this pull request Jul 4, 2024
Open
@jo-bao jo-bao added the enhancement New feature or request label Jul 4, 2024
Johannes Bao added 8 commits July 4, 2024 10:30
Merge remote-tracking branch 'origin/dev' into jb/#167-enhanceinit
7d05625 
# Conflicts:
#	src/main/java/edu/ie3/simona/api/data/results/ExtResultData.java
#	src/main/java/edu/ie3/simona/api/data/results/ontology/ProvideResultEntities.java
Merge remote-tracking branch 'origin/dev' into jb/#167-enhanceinit
77dbda6
ext simulation with storage
72d1f12
fixing tests
6d98e9b
improve docs
ebfeda0
fixing pmd?
cf22d84
fixing pmd?
2207a45
em data test
aee53bb
@jo-bao jo-bao marked this pull request as ready for review September 21, 2024 13:25
danielfeismann
danielfeismann requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enhancing the API! I have some questions and points. Please have also a look if some of the sonarqube / codacy issues can be handled.

src/main/java/edu/ie3/simona/api/data/em/ontology/ProvideEmSetPointData.java Show resolved Hide resolved
src/main/java/edu/ie3/simona/api/data/em/ExtEmData.java Outdated Show resolved Hide resolved
src/main/java/edu/ie3/simona/api/data/em/ExtEmData.java Show resolved Hide resolved
src/main/java/edu/ie3/simona/api/data/em/ExtEmData.java Outdated Show resolved Hide resolved
src/main/java/edu/ie3/simona/api/data/em/ExtEmData.java Show resolved Hide resolved
src/test/groovy/edu/ie3/simona/api/data/em/ExtEmDataTest.groovy Outdated Show resolved Hide resolved
src/test/groovy/edu/ie3/simona/api/data/em/ExtEmDataTest.groovy Show resolved Hide resolved
src/test/groovy/edu/ie3/simona/api/data/em/ExtEmDataTest.groovy Show resolved Hide resolved
src/test/groovy/edu/ie3/simona/api/data/results/ExtResultDataTest.groovy Show resolved Hide resolved
src/main/java/edu/ie3/simona/api/simulation/mapping/ExtEntityMapping.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann requested changes

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

Requested changes must be addressed to merge this pull request.

Assignees

@jo-bao jo-bao

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable initialization of primary data and result data
2 participants
@jo-bao @danielfeismann