Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle Resource Recommendations #1737

Closed
S-Warmenhoven opened this issue May 6, 2020 · 4 comments
Closed

Toggle Resource Recommendations #1737

S-Warmenhoven opened this issue May 6, 2020 · 4 comments
Assignees
@AlineRibeiro @S-Warmenhoven
Labels
react ruby on rails

Comments

@S-Warmenhoven
Copy link
Contributor

Description

Toggle the display of Resource Recommendations in Moment Post

Screenshots

toggle_resource_recommendations

Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!
@welcome
Copy link

welcome bot commented May 6, 2020

Thank you for opening this issue with us! If you haven't already, please follow these next steps to officially join our contributor community.

S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 6, 2020
@S-Warmenhoven
[ifmeorg#1737] Display new toggle button on Moment edit page
1c61787
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 6, 2020
@S-Warmenhoven
[ifmeorg#1737] Toggle works for moment new and edit
8d85ad3
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@S-Warmenhoven
[ifmeorg#1737] Refactored and rubocop
25a1103
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@S-Warmenhoven
[ifmeorg#1737] Translation for Hindi
a8c278b
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@S-Warmenhoven
[ifmeorg#1737] Translate Norwegian
90276c5
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@S-Warmenhoven
[ifmeorg#1737] Translate Dutch
19618b9
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@S-Warmenhoven
[ifmeorg#1737] Translate Swedish
1db5d10
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@S-Warmenhoven
[ifmeorg#1737] Translate Vietnamese
7ce26b6
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@S-Warmenhoven
[ifmeorg#1737] Translate German
856c9b5
AlineRibeiro added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@AlineRibeiro
[ifmeorg#1737] Add resource_recommendation column on moments table
729d114
AlineRibeiro pushed a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@S-Warmenhoven @AlineRibeiro
[ifmeorg#1737] Toggle works for moment new and edit
cd797ea
AlineRibeiro pushed a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@S-Warmenhoven @AlineRibeiro
[ifmeorg#1737] Refactored and rubocop
473909b
AlineRibeiro added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@AlineRibeiro
[ifmeorg#1737] Transalte resource_recommendations into Brazilian Port…
18f8e69 
…uguese
AlineRibeiro added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@AlineRibeiro
[ifmeorg#1737] Transalte resource_recommendations into Spanish
1d8a99e
AlineRibeiro added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@AlineRibeiro
[ifmeorg#1737] Transalte resource_recommendations into French
048ff54
AlineRibeiro added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@AlineRibeiro
[ifmeorg#1737] Transalte resource_recommendations into Italian
167ee3d
AlineRibeiro added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@AlineRibeiro
[ifmeorg#1737] Transalte resource_recommendations into Chinese
335ca7d
AlineRibeiro added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@AlineRibeiro
[ifmeorg#1737] Fix French translation
eb4dc2e
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@S-Warmenhoven
[ifmeorg#1737] Test if MomentsFormHelper #edit and #create returns co…
a7d508b 
…rrect props for resource recommendations toggle
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@S-Warmenhoven
[ifmeorg#1737] Test if toggle updates moment.resource_recommendations…
d3d35da 
… in db
AlineRibeiro added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@AlineRibeiro
[ifmeorg#1737] Test if correct links are displayed on moment show
6313341
AlineRibeiro added a commit to TeamBits-2020/ifme that referenced this issue May 7, 2020
@AlineRibeiro
[ifmeorg#1737] Test if resource links are not displayed when user cho…
d6fda4d 
…oses so
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 8, 2020
@S-Warmenhoven
[ifmeorg#1737] Updated schema and seed file
22bc905
@S-Warmenhoven S-Warmenhoven mentioned this issue May 8, 2020
Merged
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 8, 2020
@S-Warmenhoven
[ifmeorg#1737] Refactored code to be dry
ea09089
S-Warmenhoven added a commit to TeamBits-2020/ifme that referenced this issue May 11, 2020
@S-Warmenhoven
[ifmeorg#1737] Resolved merge conflicts after Rails 6 upgrade
7dba3b8
julianguyen pushed a commit that referenced this issue May 11, 2020
@S-Warmenhoven @AlineRibeiro
Toggle resource recommendations (#1738)
c7ddc23 
* [#1737] Display new toggle button on Moment edit page

* Add resource_recommendation column on moments table

* [#1737] Toggle works for moment new and edit

* [#1737] Refactored and rubocop

* [#1737] Translation for Hindi

* [#1737] Translate Norwegian

* [#1737] Translate Dutch

* [#1737] Translate Swedish

* [#1737] Translate Vietnamese

* [#1737] Add resource_recommendation column on moments table

* [#1737] Toggle works for moment new and edit

* [#1737] Refactored and rubocop

* [#1737] Transalte resource_recommendations into Brazilian Portuguese

* [#1737] Transalte resource_recommendations into Spanish

* [#1737] Translate German

* [#1737] Transalte resource_recommendations into French

* [#1737] Transalte resource_recommendations into Italian

* [#1737] Transalte resource_recommendations into Chinese

* [#1737] Fix French translation

* [#1737] Test if MomentsFormHelper #edit and #create returns correct props for resource recommendations toggle

* [#1737] Test if toggle updates moment.resource_recommendations in db

* [#1737] Test if correct links are displayed on moment show

* [#1737] Test if resource links are not displayed when user chooses so

* [#1737] Updated schema and seed file

* [#1737] Refactored code to be dry

Co-authored-by: Aline Ribeiro <[email protected]>
bmwachajr pushed a commit that referenced this issue May 20, 2020
@S-Warmenhoven @AlineRibeiro
Toggle resource recommendations (#1738)
ded22d4 
* [#1737] Display new toggle button on Moment edit page

* Add resource_recommendation column on moments table

* [#1737] Toggle works for moment new and edit

* [#1737] Refactored and rubocop

* [#1737] Translation for Hindi

* [#1737] Translate Norwegian

* [#1737] Translate Dutch

* [#1737] Translate Swedish

* [#1737] Translate Vietnamese

* [#1737] Add resource_recommendation column on moments table

* [#1737] Toggle works for moment new and edit

* [#1737] Refactored and rubocop

* [#1737] Transalte resource_recommendations into Brazilian Portuguese

* [#1737] Transalte resource_recommendations into Spanish

* [#1737] Translate German

* [#1737] Transalte resource_recommendations into French

* [#1737] Transalte resource_recommendations into Italian

* [#1737] Transalte resource_recommendations into Chinese

* [#1737] Fix French translation

* [#1737] Test if MomentsFormHelper #edit and #create returns correct props for resource recommendations toggle

* [#1737] Test if toggle updates moment.resource_recommendations in db

* [#1737] Test if correct links are displayed on moment show

* [#1737] Test if resource links are not displayed when user chooses so

* [#1737] Updated schema and seed file

* [#1737] Refactored code to be dry

Co-authored-by: Aline Ribeiro <[email protected]>
@bmwachajr
Copy link
Contributor

Hi @S-Warmenhoven can we close this issue?

@S-Warmenhoven
Copy link
Contributor Author

Hi @bmwachajr
Yes, we can. Sorry if I was required to do that and didn't. I'm still new to contributing to Open Source projects, and this was my first created issue, so I wasn't sure what the policy was and if I can just close issues for the project myself. Should I just go ahead and do that or should I leave it for you to close? Also, my team worked on issue #1713 and it is finished and merged. However, that issue was created by Julia. Do we leave it for her (as the creator of the issue) to close it, or do we as the assignees close it after it's completed? Thank you in advance for your guidance.

@julianguyen
Copy link
Member

No worries! Feel free to close it, if you made the issue you feel like the requirements have been completed.

bianca93 pushed a commit to bianca93/ifme that referenced this issue Jun 24, 2020
@S-Warmenhoven @AlineRibeiro @bianca93
Toggle resource recommendations (ifmeorg#1738)
393e0ef 
* [ifmeorg#1737] Display new toggle button on Moment edit page

* Add resource_recommendation column on moments table

* [ifmeorg#1737] Toggle works for moment new and edit

* [ifmeorg#1737] Refactored and rubocop

* [ifmeorg#1737] Translation for Hindi

* [ifmeorg#1737] Translate Norwegian

* [ifmeorg#1737] Translate Dutch

* [ifmeorg#1737] Translate Swedish

* [ifmeorg#1737] Translate Vietnamese

* [ifmeorg#1737] Add resource_recommendation column on moments table

* [ifmeorg#1737] Toggle works for moment new and edit

* [ifmeorg#1737] Refactored and rubocop

* [ifmeorg#1737] Transalte resource_recommendations into Brazilian Portuguese

* [ifmeorg#1737] Transalte resource_recommendations into Spanish

* [ifmeorg#1737] Translate German

* [ifmeorg#1737] Transalte resource_recommendations into French

* [ifmeorg#1737] Transalte resource_recommendations into Italian

* [ifmeorg#1737] Transalte resource_recommendations into Chinese

* [ifmeorg#1737] Fix French translation

* [ifmeorg#1737] Test if MomentsFormHelper #edit and #create returns correct props for resource recommendations toggle

* [ifmeorg#1737] Test if toggle updates moment.resource_recommendations in db

* [ifmeorg#1737] Test if correct links are displayed on moment show

* [ifmeorg#1737] Test if resource links are not displayed when user chooses so

* [ifmeorg#1737] Updated schema and seed file

* [ifmeorg#1737] Refactored code to be dry

Co-authored-by: Aline Ribeiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlineRibeiro AlineRibeiro

@S-Warmenhoven S-Warmenhoven

Labels
react ruby on rails
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@julianguyen @bmwachajr @AlineRibeiro @S-Warmenhoven