Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaving the search field blank and clicking "Search" should return all books akin to the default behavior. #245

Open
avni opened this issue Sep 4, 2024 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@avni
Copy link
Member

avni commented Sep 4, 2024

Describe the bug/problem

Leaving the search field blank and pressing "Search" results in no books from the library being returned. I think it's a better user experience if blank returns all books as that is the default behavior when you first go to the page.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'http://box/books/'
  2. Observe that all books in library are shown
  3. Click the "Search" button on the upper left of the page
  4. See that no books appear.

Expected behavior

Leaving the search field blank and clicking "Search" should return all books akin to the default behavior.

Screenshots

Default Behavior:
Image

Leaving Search Text Field Blank and Pressing Search

Image

Environment (please complete the following information):

@holta
Copy link
Member

holta commented Sep 4, 2024

Common corner cases need to not drive teachers crazy: We can debate what that means?

Either way, the behavior needs to be very clear, and very consistent!

Related:

@holta holta added the question Further information is requested label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants