-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor API #27
Comments
Specifically, I noticed some duplicate code between Regarding CoffeeScript (CS), that is an interesting decision to make. I've been doing some reading and it seems like a heated topic with many pros and cons either way. I wouldn't lose much sleep over the loss of CoffeeScript (I'm not a Ruby guy after all), but I do think that this can be an opportunity to improve upon it rather than "downgrade" to JS. Ruling out CS and JS, the main alternatives are Dart and TypeScript (TS). As an MS employee I may be biased, but I think TS is the clear winner: http://programmers.stackexchange.com/a/193582/132066. Some even go as far as to say Dart is dead: https://medium.com/@richardeng/dart-is-dead-aedced9fd3d1. If you go that route I would recommend Visual Studio (with Web Essentials), but grunt will still be an option: https://www.npmjs.com/package/grunt-typescript. Having said that, knockout-datatable has (and probably will in the future) a small enough code base that it could probably get away with pure JS. |
I think we'll stick with either JS or CoffeeScript, as those are what Immense uses in-house. |
That just means you need to convince the rest of Immense to move to TS ;) |
Since the addition of server-side pagination, there is a lot of room for refactoring (e.g. some public methods could be made private, code styling, etc.).
I also propose that we switch to pure Javascript to remove the dependency on CoffeeScript-related compilation steps, that we add a grunt watch for development, and that we add a linting step to the minification process.
The text was updated successfully, but these errors were encountered: