Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix nidm_pValueUncorrected defined twice with different ids #421

Open
cmaumet opened this issue Sep 11, 2017 · 0 comments
Open

Prefix nidm_pValueUncorrected defined twice with different ids #421

cmaumet opened this issue Sep 11, 2017 · 0 comments
Labels
next minor release Terms

Comments

@cmaumet
Copy link
Member

cmaumet commented Sep 11, 2017

https://github.com/incf-nidash/nidm/blob/master/nidm/nidm-results/terms/prefixes.csv#L177

https://github.com/incf-nidash/nidm/blob/master/nidm/nidm-results/terms/prefixes.csv#L216

For consistency with FWE and FDR p-values, we could change the uncorrected p-value class label in
'Uncorrected p-value' which would change the prefix into 'nidm_UncorrectedPValue'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next minor release Terms
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khelm @cmaumet