Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Z infinite #52

Open
cmaumet opened this issue Jul 23, 2018 · 2 comments
Open

Removing Z infinite #52

cmaumet opened this issue Jul 23, 2018 · 2 comments

Comments

@cmaumet
Copy link
Member

cmaumet commented Jul 23, 2018

Similarly to what we have done in the SPM NIDM viewer, could we recompute Z from P when Z has an infinite value : cf. incf-nidash/nidmresults-spmhtml#39?

@gllmflndn: the Inf are initially created by SPM at https://github.com/spm/spm12/blob/master/spm_list.m#L464-L470, what do you think of this proposed update (in the NIDM exporter or in SPM?)?

@gllmflndn
Copy link
Contributor

This is a problem of numerical precision at the extreme tail of the distribution; the tolerance on the p-value is set to 10*eps:
https://github.com/spm/spm12/blob/master/spm_list.m#L231-L233
See what example what is made here for a t to z conversion:
https://github.com/SnPM-toolbox/SnPM-devel/blob/master/snpm_t2z.m
@nicholst any thought?

@nicholst
Copy link

nicholst commented Aug 2, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants