Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and document the Asynchromix + eth example #425

Open
5 tasks
sbellem opened this issue Mar 3, 2020 · 0 comments
Open
5 tasks

Review and document the Asynchromix + eth example #425

sbellem opened this issue Mar 3, 2020 · 0 comments
Assignees
@sbellem
Labels
ethereum integration integration with ethereum/web3

Comments

@sbellem
Copy link
Collaborator

sbellem commented Mar 3, 2020 •
edited
Loading

Note that there's already a work-in-progress PR (:#424) for this but this issue will serve as some kind of checklist of things that need to be done.

Make sure that the Asynchromix example, which uses Ethereum as an MPC coordinator, works as expected. In that process, also document the app a bit. Some documentation can be added to https://github.com/initc3/HoneyBadgerMPC/tree/dev/apps/tutorial#iii-blockchain-integration.

Some notes

The class web3.contract.ConciseContract "is deprecated in favor of the ContractCaller API or the verbose syntax."

Perhaps not essential but would be nice ...

  • unit tests and/or integration tests -- mostly to prevent regression has the code evolves
  • upgrade solidity and node versions in Dockerfile
@sbellem sbellem added the ethereum integration integration with ethereum/web3 label Mar 3, 2020
@sbellem sbellem self-assigned this Mar 3, 2020
@sbellem sbellem changed the title Revisit and document the Asynchromix + eth example Review and document the Asynchromix + eth example Mar 3, 2020
@sbellem sbellem mentioned this issue Mar 3, 2020
Merged
sbellem added a commit to sbellem/HoneyBadgerMPC that referenced this issue Mar 4, 2020
@sbellem
Fix asynchromix example
095cf04 
* Catch web3 tx not found exception (API changed in versions > 5.0.0)
* Fix missing one_minus_ones elements
* Refresh the cache of preprocessed elements after the writing to file
  step is done. There was a line `pp_elements.init_mixins()` which looks
  like it was expected to do something similar but the method
  (`init_mixins()`) does not exist. Perhaps it can be implemented in the
  future.

Related to initc3#425
sbellem added a commit to sbellem/HoneyBadgerMPC that referenced this issue May 13, 2020
@sbellem
Fix asynchromix example
7db65d7 
* Catch web3 tx not found exception (API changed in versions > 5.0.0)
* Fix missing one_minus_ones elements
* Refresh the cache of preprocessed elements after the writing to file
  step is done. There was a line `pp_elements.init_mixins()` which looks
  like it was expected to do something similar but the method
  (`init_mixins()`) does not exist. Perhaps it can be implemented in the
  future.

Related to initc3#425
sbellem added a commit that referenced this issue May 14, 2020
@sbellem
Fix asynchromix example
3ccc883 
* Catch web3 tx not found exception (API changed in versions > 5.0.0)
* Fix missing one_minus_ones elements
* Refresh the cache of preprocessed elements after the writing to file
  step is done. There was a line `pp_elements.init_mixins()` which looks
  like it was expected to do something similar but the method
  (`init_mixins()`) does not exist. Perhaps it can be implemented in the
  future.

Related to #425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbellem sbellem

Labels
ethereum integration integration with ethereum/web3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbellem