Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] 블랙홀 유저 BlackholeManager 스케쥴러 관련 구조 개선 #1294

Closed
enaenen opened this issue Aug 12, 2023 · 2 comments · Fixed by #1305
Closed

[BE] 블랙홀 유저 BlackholeManager 스케쥴러 관련 구조 개선 #1294

enaenen opened this issue Aug 12, 2023 · 2 comments · Fixed by #1305
Assignees
@enaenen
Labels
BE Backend tasks BUG Issuing bugs REFACTOR Restruct cords without altering logics

Comments

@enaenen
Copy link
Collaborator

enaenen commented Aug 12, 2023

버그 설명

현재 스케쥴러가 돈 직후 블랙홀을 얻은 유저들에 대한 문제가 발생

  • 스케쥴러는 1주일에 한번만 도는중
  1. 스케쥴러가 블랙홀에 빠질 유저인것을 확인
  2. 이후 유저가 과제를 통과하여 블랙홀이 늘어남
  3. 다시 스케쥴러가 돌기전, 유저가 대여 요청
  4. 대여 정책에서, throw

재현 방법

  • 블랙홀 1일 이내로 남은 유저
  • (BlackholeManager) 스케쥴러를 실행
  • 유저에 블랙홀을 3일이상 추가
  • 서버 날짜를 +2일
  • 위에서 해당 유저로 대여

기대했던 정상 동작

구조적 문제

시스템 환경 (선택 사항)

No response

추가 건의사항

No response
@enaenen enaenen added the BE Backend tasks label Aug 12, 2023
@enaenen enaenen self-assigned this Aug 12, 2023
@enaenen
Copy link
Collaborator Author

enaenen commented Aug 12, 2023

Cabi DB 에서 블랙홀에 빠졌다고 생각되는 유저가 대여를 시도했을시,
바로 Throw 하는것이아닌, intra API 로 해당유저의 블랙홀일수를 한번 확인한 후 처리

@enaenen
Copy link
Collaborator Author

enaenen commented Aug 12, 2023

현재는 @sichoi42
LentPolicy 에서 블랙홀 확인해는 부분을 비활성화

@enaenen enaenen added BUG Issuing bugs REFACTOR Restruct cords without altering logics labels Aug 12, 2023
sichoi42 added a commit that referenced this issue Aug 12, 2023
@sichoi42
[BE] FIX: 문제 발생 코드 주석처리 #1294
93d4483
sichoi42 added a commit that referenced this issue Aug 12, 2023
@sichoi42
Merge pull request #1295 from innovationacademy-kr/be/dev/refactor_bl…
7f50d89 
…ackhole_scheduler/#1294

[BE] LentPolicy 블랙홀 검증 로직 삭제
sichoi42 added a commit that referenced this issue Aug 12, 2023
@sichoi42
[BE] FIX: 문제 발생 코드 주석처리 #1294
c3febef
sichoi42 added a commit that referenced this issue Aug 12, 2023
@sichoi42
Merge pull request #1296 from innovationacademy-kr/be/dev/refactor_bl…
461b79d 
…ackhole_scheduler/#1294

[BE] FIX: 문제 발생 코드 주석처리 #1294
enaenen added a commit that referenced this issue Aug 14, 2023
@enaenen
Merge branch 'be/dev/refactor_blackhole_scheduler/#1294' of github.co…
af42fbf 
…m:innovationacademy-kr/42cabi into be/dev/refactor_blackhole_scheduler/#1294
@enaenen enaenen mentioned this issue Aug 14, 2023
Merged
9 tasks
@enaenen enaenen linked a pull request Aug 14, 2023 that will close this issue
[BE] Blackhole 유저 대여시 재확인 로직 #1304 & 밴 유저가 만료시간 볼 수 있도록 변경 #1294 #1305
Merged
9 tasks
enaenen added a commit that referenced this issue Aug 18, 2023
@enaenen
Merge branch 'dev' of github.com:innovationacademy-kr/42cabi into be/…
8e35441 
…dev/refactor_blackhole_scheduler/#1294
enaenen added a commit that referenced this issue Aug 18, 2023
@enaenen
Merge pull request #1305 from innovationacademy-kr/be/dev/refactor_bl…
4ec10d7 
…ackhole_scheduler/#1294

[BE] Blackhole 유저 대여시 재확인 로직 #1304 & 밴 유저가 만료시간 볼 수 있도록 변경 #1294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enaenen enaenen

Labels
BE Backend tasks BUG Issuing bugs REFACTOR Restruct cords without altering logics
Projects
None yet
Milestone
No milestone
1 participant
@enaenen