Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.0 release only #308

Closed
Kevinrob opened this issue Apr 19, 2021 · 4 comments
Closed

Ruby 3.0 release only #308

Kevinrob opened this issue Apr 19, 2021 · 4 comments

Comments

@Kevinrob
Copy link
Contributor

We would like to use Ruby 3.0 and we use makara.

The release v0.5.0 crash with Ruby 3.0.
The release v0.6.0.pre crash with ActiveRecord::StatementInvalid: PG::ReadOnlySqlTransaction: ERROR: cannot execute UPDATE in a read-only transaction (this is a pre-release so I understand).

Maybe, we can release a version v0.5.1 with only #283 ?
Like that, everyone can use Ruby 3.0 and we can stabilise v0.6.0.pre.

What do you think?

@Kevinrob
Copy link
Contributor Author

ping @scashin133 @mlarraz 😊

@dvandersluis
Copy link

I'm also trying to get Ruby 3 going and only could succeed with 0.6.0.pre but it's causing an incompatibility with the distributed_reads gem.

@mlarraz
Copy link
Member

mlarraz commented Jun 4, 2021

Please try https://github.com/instacart/makara/releases/tag/v0.5.1 and report back if you still see the issue.

@mlarraz
Copy link
Member

mlarraz commented Jun 15, 2021

We released this to production on our apps without issue so I'm going to mark this closed.

@mlarraz mlarraz closed this as completed Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants