Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When blacklist is disabled, gracefully error handling causes infinite retries. #381

Open
rahul342 opened this issue Oct 13, 2023 · 0 comments
Open

When blacklist is disabled, gracefully error handling causes infinite retries. #381

rahul342 opened this issue Oct 13, 2023 · 0 comments

Comments

@rahul342
Copy link

Currently if disable_blacklist is set to true and if you get an error that's gracefully handled, makara will simply keep retrying infinitely.

Doesn't feel like this should be the desired behavior because if you end up in a bad state, this logic will make it worse.

If blacklisting is disabled, should it then simply also disable graceful error handling?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rahul342