From acbd40c4dc3d2ac07c53f9499a7c218c70fb5c77 Mon Sep 17 00:00:00 2001 From: Matyas Szabo Date: Fri, 30 Aug 2024 13:36:57 +0200 Subject: [PATCH] refactor(ui-table,ui-tag): remove not needed eslint-disable --- packages/ui-table/src/Table/__new-tests__/Table.test.tsx | 4 ---- packages/ui-tag/src/Tag/__new-tests__/Tag.test.tsx | 4 ---- 2 files changed, 8 deletions(-) diff --git a/packages/ui-table/src/Table/__new-tests__/Table.test.tsx b/packages/ui-table/src/Table/__new-tests__/Table.test.tsx index 2648fd4da6..ddf2e955dd 100644 --- a/packages/ui-table/src/Table/__new-tests__/Table.test.tsx +++ b/packages/ui-table/src/Table/__new-tests__/Table.test.tsx @@ -33,8 +33,6 @@ import type { TableProps } from '../props' import type { TableColHeaderProps } from '../ColHeader/props' import { runAxeCheck } from '@instructure/ui-axe-check' -// see https://github.com/vitest-dev/eslint-plugin-vitest/issues/511 -// eslint-disable-next-line vitest/valid-describe-callback describe('', async () => { let consoleErrorMock: MockInstance @@ -208,8 +206,6 @@ describe('
', async () => { expect(table).toHaveTextContent('Foo') }) - // see https://github.com/vitest-dev/eslint-plugin-vitest/issues/511 - // eslint-disable-next-line vitest/valid-describe-callback describe('when table is sortable', async () => { const renderSortableTable = ( props: TableColHeaderProps | null, diff --git a/packages/ui-tag/src/Tag/__new-tests__/Tag.test.tsx b/packages/ui-tag/src/Tag/__new-tests__/Tag.test.tsx index 60f939cd24..b874cf6da2 100644 --- a/packages/ui-tag/src/Tag/__new-tests__/Tag.test.tsx +++ b/packages/ui-tag/src/Tag/__new-tests__/Tag.test.tsx @@ -35,8 +35,6 @@ import { View } from '@instructure/ui-view' const originalOmitViewProps = View.omitViewProps -// https://github.com/vitest-dev/eslint-plugin-vitest/issues/511 -// eslint-disable-next-line vitest/valid-describe-callback describe('', async () => { beforeAll(() => { // View component read Component.name instead of Component.displayName @@ -95,8 +93,6 @@ describe('', async () => { expect(axeCheck).toBe(true) }) - // https://github.com/vitest-dev/eslint-plugin-vitest/issues/511 - // eslint-disable-next-line vitest/valid-describe-callback describe('when passing down props to View', async () => { const allowedProps: Partial = { margin: 'small',