Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version on binder does not plot. #70

Open
koldunovn opened this issue Apr 23, 2020 · 15 comments
Open

Version on binder does not plot. #70

koldunovn opened this issue Apr 23, 2020 · 15 comments

Comments

@koldunovn
Copy link

Currently, the version that is opened with the binder does not make the plot, even if I click the Plot button.

@martindurant
Copy link
Member

I believe this is the same as #69
I will try to make some time to put things right.

@martindurant
Copy link
Member

Works OK now?

@rsignell-usgs
Copy link
Collaborator

rsignell-usgs commented Apr 23, 2020

I clicked the binder link, ran the notebook, got a plot, but then (yipes) I get this:
https://www.youtube.com/watch?v=50dylR5d3-M

@martindurant
Copy link
Member

Constant unzooming! Is there an issue for this?

@rsignell-usgs
Copy link
Collaborator

Do you think it's a holoviews/geoviews issue or an xrviz issue?

@martindurant
Copy link
Member

As far as I know, xrviz creates the plot and then leaves it alone. It is plausible that the layout is being recalculated somehow... @philippjfr , your thoughts?

@philippjfr
Copy link
Contributor

Yeah something in holoviews. It's probably to do with aspect handling. Is this using recent HoloViews yet?

@martindurant
Copy link
Member

The script uses "current" versions (whatever conda gives us from conda-forge on py37)

@martindurant
Copy link
Member

@rsignell-usgs , if you still have this open, would be good to post the versions binder ended up using

@rsignell-usgs
Copy link
Collaborator

rsignell-usgs commented Apr 23, 2020

# packages in environment at /srv/conda/envs/notebook:
#
# Name                    Version                   Build  Channel

bokeh                     2.0.1            py37hc8dfbb8_0    conda-forge
datashader                0.10.0                     py_0    conda-forge
holoviews                 1.13.2             pyh9f0ad1d_0    conda-forge
hvplot                    0.5.2                      py_0    conda-forge
geoviews                  1.8.1                      py_0    conda-forge
geoviews-core             1.8.1                      py_0    conda-forge
panel                     0.9.5                      py_1    conda-forge
python                    3.7.6           h8356626_5_cpython    conda-forge

@philippjfr
Copy link
Contributor

Okay, so definitely latest, I'll try to reproduce.

@philippjfr
Copy link
Contributor

Okay, I see the same thing. Will see if I can get a 1.13.3 release with a fix out very soon.

@koldunovn
Copy link
Author

The plot works for me now on the binder, thanks!

@rsignell-usgs
Copy link
Collaborator

rsignell-usgs commented Apr 24, 2020

@philippjfr I'm so glad you could replicate the zooming out feedback loop issue and it sounds like you see the solution also. Awesome!

@philippjfr
Copy link
Contributor

Just wish we had an automated way to catch these kinds of regressions. Unfortunately testing client-server interactions in a browser is hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants