From fe1535eb7c7e412aee685ce8f26605034024c3c3 Mon Sep 17 00:00:00 2001 From: Md Abdullah Shahneous Bari <98356296+mshahneo@users.noreply.github.com> Date: Thu, 3 Oct 2024 15:51:25 -0500 Subject: [PATCH] [ExecutionEngine] Modify the way we pass IGC flags. (#912) Passing multiple finalizer flags together seems to have caused issues in some IGC versions as not being recognized. As a result, passing one finalizer flag at a time. --- .../LEVELZERORUNTIME/LevelZeroRuntimeWrappers.cpp | 8 ++++---- lib/ExecutionEngine/SYCLRUNTIME/SyclRuntimeWrappers.cpp | 7 +++---- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/lib/ExecutionEngine/LEVELZERORUNTIME/LevelZeroRuntimeWrappers.cpp b/lib/ExecutionEngine/LEVELZERORUNTIME/LevelZeroRuntimeWrappers.cpp index ebc6f2afe..3a193f91e 100644 --- a/lib/ExecutionEngine/LEVELZERORUNTIME/LevelZeroRuntimeWrappers.cpp +++ b/lib/ExecutionEngine/LEVELZERORUNTIME/LevelZeroRuntimeWrappers.cpp @@ -402,10 +402,10 @@ static ze_module_handle_t loadModule(GPUL0QUEUE *queue, const void *data, } // enable large register file if needed if (getenv("IMEX_ENABLE_LARGE_REG_FILE")) { - build_flags += - " -doubleGRF -Xfinalizer -noLocalSplit -Xfinalizer " - "-DPASTokenReduction -Xfinalizer -SWSBDepReduction -Xfinalizer " - "'-printregusage -enableBCR' "; + build_flags += "-doubleGRF -Xfinalizer -noLocalSplit -Xfinalizer " + "-DPASTokenReduction -Xfinalizer -SWSBDepReduction " + "-Xfinalizer -printregusage -Xfinalizer -enableBCR"; + ; } desc.format = ZE_MODULE_FORMAT_IL_SPIRV; diff --git a/lib/ExecutionEngine/SYCLRUNTIME/SyclRuntimeWrappers.cpp b/lib/ExecutionEngine/SYCLRUNTIME/SyclRuntimeWrappers.cpp index 02d94d1f1..a5022fcb4 100644 --- a/lib/ExecutionEngine/SYCLRUNTIME/SyclRuntimeWrappers.cpp +++ b/lib/ExecutionEngine/SYCLRUNTIME/SyclRuntimeWrappers.cpp @@ -234,10 +234,9 @@ static ze_module_handle_t loadModule(GPUSYCLQUEUE *queue, const void *data, } // enable large register file if needed if (getenv("IMEX_ENABLE_LARGE_REG_FILE")) { - build_flags += - " -doubleGRF -Xfinalizer -noLocalSplit -Xfinalizer " - "-DPASTokenReduction -Xfinalizer -SWSBDepReduction -Xfinalizer " - "'-printregusage -enableBCR' "; + build_flags += "-doubleGRF -Xfinalizer -noLocalSplit -Xfinalizer " + "-DPASTokenReduction -Xfinalizer -SWSBDepReduction " + "-Xfinalizer -printregusage -Xfinalizer -enableBCR"; } desc.pBuildFlags = build_flags.c_str(); auto zeDevice = sycl::get_native(