Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The unittest cases to execut test_orphan_workers is too long. #1381

Open
workingloong opened this issue Dec 8, 2024 · 0 comments · May be fixed by #1403
Open

The unittest cases to execut test_orphan_workers is too long. #1381

workingloong opened this issue Dec 8, 2024 · 0 comments · May be fixed by #1403
Assignees
@BalaBalaYi @samplise
Labels
dev issue for development report

Comments

@workingloong
Copy link
Collaborator

Describe the bug

We should shorten the execution duration to execute UT.

============================= slowest 10 durations =============================
90.19s call     dlrover/python/tests/test_elastic_training_agent.py::ElasticTrainingAgentRunTest::test_orphan_workers
90.17s call     dlrover/python/tests/test_elastic_training_agent.py::ElasticTrainingAgentRunTest::test_stop_workers_ascend
90.17s call     dlrover/python/tests/test_elastic_training_agent.py::ElasticTrainingAgentRunTest::test_no_orphan_workers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BalaBalaYi BalaBalaYi

@samplise samplise

Labels
dev issue for development report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce the sleep time to speed up UT. workingloong/dlrover
3 participants
@workingloong @BalaBalaYi @samplise