You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is a fairly common practice to add globbing catch-all style routes to your Router.map to handle invalid links and whatnot. Since these catch-all routes will always match, ember-href-to's link handler will happily transition into the 404 route.
In deployments where a given root is fully owned by the Ember app, this is a totally fine assumption to make. However, in scenarios where things outside of your Ember app also live on the same domain (i.e. you are transitioning from server render pages to Ember app pages) you actually want to ignore the 404 route when deciding if a given link click is handleable.
Would you be open to adding support for a blacklist (an array of route names) to opt-out of the internal transition behavior?
PS: I love this addon, thank you for working on it!
The text was updated successfully, but these errors were encountered:
@rwjblue is it just catchall routes that you want to ignore? If so, it would be nice if we could detect those and ignore (possibly by default, possibly by a simple config switch). There was some previous discussion about it here, at the time is seemed that it wasn't possible to detect catchall routes.
If that option proves unfruitful, I think a blacklist of route names is fine, albeit a less elegant solution.
It is a fairly common practice to add globbing catch-all style routes to your
Router.map
to handle invalid links and whatnot. Since these catch-all routes will always match,ember-href-to
's link handler will happily transition into the404
route.In deployments where a given root is fully owned by the Ember app, this is a totally fine assumption to make. However, in scenarios where things outside of your Ember app also live on the same domain (i.e. you are transitioning from server render pages to Ember app pages) you actually want to ignore the 404 route when deciding if a given link click is handleable.
Would you be open to adding support for a blacklist (an array of route names) to opt-out of the internal transition behavior?
PS: I love this addon, thank you for working on it!
The text was updated successfully, but these errors were encountered: