Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Termination signal handler is slow #384

Open
sander2 opened this issue Oct 10, 2022 · 0 comments
Open

Termination signal handler is slow #384

sander2 opened this issue Oct 10, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@sander2
Copy link
Member

sander2 commented Oct 10, 2022

Ctrl+c signal is not immediately handled. We thought we had addressed this through #360 but either there has been a regression, or it didn't fix the issue after all.

This is the log I obtained when I started the vault directly (i.e. not using the runner):

Oct 07 11:49:38.862  INFO vault::system: Initializing metrics...
q^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C
Oct 07 11:50:26.701  INFO vault::system: Waiting for new block...
Oct 07 11:50:26.701  INFO vault: Received termination signal: 2

Update
This is most likely because the future is busy-waiting, i.e. it does not return Poll::Pending for a long time, so the select that catches the shutdown signal handler does not get the opportunity to cancel the future.

@sander2 sander2 added the bug Something isn't working label Oct 10, 2022
@nud3l nud3l added this to Backlog Jan 3, 2023
@nud3l nud3l moved this to Todo ⏳ in Backlog Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants