Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync check not correct #408

Open
sander2 opened this issue Nov 2, 2022 · 0 comments
Open

Sync check not correct #408

sander2 opened this issue Nov 2, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@sander2
Copy link
Member

sander2 commented Nov 2, 2022

We currently check if the bitcoin chain has been synced like this:

if !info.initial_block_download || info.verification_progress.eq(&1.0) {

However, neither initial_block_download nor verification_progress can be relied upon, see bitcoin/bitcoin#26432 and bitcoin/bitcoin#26433

According to stackexchange we should compare the blocks and headers fields - if they are equal then the bitcoin node is synced.

@sander2 sander2 added the bug Something isn't working label Nov 2, 2022
@nud3l nud3l added this to Backlog Jan 3, 2023
@nud3l nud3l moved this to Todo ⏳ in Backlog Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant