Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undetected issue payment #424

Open
sander2 opened this issue Dec 5, 2022 · 0 comments
Open

Undetected issue payment #424

sander2 opened this issue Dec 5, 2022 · 0 comments

Comments

@sander2
Copy link
Member

sander2 commented Dec 5, 2022

As reported by Quarkslabs:

Description: If a user makes multiple issue requests and pays them in the same Bitcoin trans-action, then the second payment output will be missed by the vaults. This is due to the use of find_map in the process_transaction_and_execute_issue function which only returns the first matching element as stated in its documentation.
Recommandation: A possible fix for this issue would be turning the if let construct into a while let construct. However this alone should not be enough as the core of the function can return and needs to be changed accordingly.

@nud3l nud3l added this to Backlog Jan 3, 2023
@nud3l nud3l moved this to Todo ⏳ in Backlog Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant