Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pagination with after and before both specified #233

Open
wilsonianb opened this issue Oct 3, 2022 · 1 comment
Open

Support pagination with after and before both specified #233

wilsonianb opened this issue Oct 3, 2022 · 1 comment
Labels
type: specification Changes to the specification

Comments

@wilsonianb
Copy link
Contributor

The relay pagination spec supports both after and before being specified together:
https://relay.dev/graphql/connections.htm#sec-Pagination-algorithm

Rafiki currently ignores before if after is specified
https://github.com/interledger/rafiki/blob/3d30ce755b4218a777ec77f408be5d15dfa0e687/packages/backend/src/shared/baseModel.ts#L64-L74
@wilsonianb
Copy link
Contributor Author

wilsonianb commented Oct 3, 2022 •
edited
Loading

Should Open Payments list endpoint query parameters then support after/before instead of just cursor?
https://github.com/interledger/rafiki/blob/3d30ce755b4218a777ec77f408be5d15dfa0e687/packages/backend/src/shared/pagination.ts#L9-L20

@wilsonianb wilsonianb added the good first issue Good for newcomers label Oct 3, 2022
@sabineschaller sabineschaller transferred this issue from interledger/rafiki Dec 12, 2022
@wilsonianb wilsonianb mentioned this issue Dec 15, 2022
Merged
4 tasks
@mkurapov mkurapov added type: specification Changes to the specification and removed good first issue Good for newcomers labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: specification Changes to the specification
Projects
Open Payments
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wilsonianb @mkurapov