Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove exchange #1502

Closed

Conversation

HessamMosleh
Copy link
Contributor

Context

Changes

remove all exchange section from wallet/backend

@github-actions github-actions bot added package: wallet/backend Wallet backend implementations type: source Source changes labels Aug 29, 2024
@Tymmmy
Copy link
Contributor

Tymmmy commented Sep 2, 2024

Hello @HessamMosleh , thank you for your enthusiasm in picking up stories for test wallet, and solving the issues. The only problem would be that you need to pick up stories that are not assigned to anyone yet, and if there is a story assigned to someone, maybe you can get in touch with them and ask them if you can take over. This story already has a branch on it, so it was already started on. Please continue on contribuiting to all interledger projects, but keep in mind the contribution guidelines.
Thank you.

@Tymmmy Tymmmy closed this Sep 2, 2024
@HessamMosleh
Copy link
Contributor Author

well when I created this PR it was not assigned to anyone but it is okay, I'll ask from story commits if possible to get the story or not from now on, thanks.

@Tymmmy
Copy link
Contributor

Tymmmy commented Sep 5, 2024

Hello @HessamMosleh, I am sorry for the confusion, you might have not noticed that it is assigned, but the history of the ticket says, 2 weeks ago it was assigned :
image

Then your branch created one week ago:
image

We look forward to your contributions for sure, it is just not possible to disregard someones work who did it aalready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: wallet/backend Wallet backend implementations type: source Source changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] New design - remove unused code
2 participants