Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings page - Disconnect wallet #108

Closed
Tracked by #67
tselit opened this issue Feb 27, 2024 · 3 comments
Closed
Tracked by #67

Settings page - Disconnect wallet #108

tselit opened this issue Feb 27, 2024 · 3 comments
Assignees
Labels
area: popup Improvements or additions to extension popup

Comments

@tselit
Copy link

tselit commented Feb 27, 2024

Context

Implement the settings page to disconnect a wallet.
A WM extension user who has previously connected their digital wallet to fund their WM payments needs to be able to disconnect their digital wallet from the WM extension.

The settings page UI:
disconnect wallet

Todos

  • For a user that already has a connected wallet address, the settings page should display the following form fields:

    • the public key that was generated by the extension during installation (read-only with ability to copy the key value)
    • the full address of the connected wallet (should be disabled and read-only)
    • the remaining balance of the wallet (should be disabled and read-only)
    • the disconnect button
  • Expire all grants / access tokens that had been issued to the extension for that wallet address.

  • For a user that has disconnected a wallet address, all the setup form fields should be enabled and allow text entry. The actions that the user can perform are to:

    • view & copy the public key
    • enter the wallet address
    • enter the amount
    • select amount type (recurring/single use)
    • connecting a wallet address
@tselit tselit added the area: popup Improvements or additions to extension popup label Feb 27, 2024
@tselit tselit added this to the WM extension 1.0.0-alpha milestone Feb 27, 2024
@tselit tselit changed the title [FEATURE REQUEST] Settings page - Disconnect wallet Feb 27, 2024
@tselit tselit moved this from Backlog to Todo in Web Monetization Extension Feb 27, 2024
@tselit tselit moved this from Todo to In Progress in Web Monetization Extension Mar 6, 2024
@raducristianpopa raducristianpopa moved this from In Progress to In Review in Web Monetization Extension Mar 12, 2024
@raducristianpopa
Copy link
Member

raducristianpopa commented Mar 12, 2024

Partially working (#169), but not clearing the storage properly.

@tselit
Copy link
Author

tselit commented Mar 14, 2024

Addressing clearing storage after wallet disconnect in #174 - waiting for review

@raducristianpopa raducristianpopa self-assigned this Mar 19, 2024
@raducristianpopa
Copy link
Member

Closed by #174.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: popup Improvements or additions to extension popup
Projects
Archived in project
Development

No branches or pull requests

2 participants