Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add radio group component #52

Closed
Tracked by #44
raducristianpopa opened this issue Dec 14, 2023 · 2 comments · Fixed by #73
Closed
Tracked by #44

Add radio group component #52

raducristianpopa opened this issue Dec 14, 2023 · 2 comments · Fixed by #73
Assignees
@dianafulga
Labels
area: popup Improvements or additions to extension popup

Comments

@raducristianpopa
Copy link
Member

raducristianpopa commented Dec 14, 2023 •
edited
Loading

Context

Todos

  • Implement a reusable radio group component
  • The component should have handling for focus, disabled and other required states
  • Consider following the WAI ARIA Radio Group pattern for a11y guidelines
@raducristianpopa raducristianpopa added the area: popup Improvements or additions to extension popup label Dec 14, 2023
@raducristianpopa raducristianpopa mentioned this issue Dec 14, 2023
Closed
9 tasks
@dianafulga dianafulga self-assigned this Jan 7, 2024
@dianafulga dianafulga moved this from Backlog to In Progress in Web Monetization Extension Jan 7, 2024
@dianafulga dianafulga moved this from In Progress to In Review in Web Monetization Extension Jan 9, 2024
@tselit
Copy link

tselit commented Jan 16, 2024 •
edited
Loading

PR should be ready for final review by EOD, 16 Jan 2024.

@dianafulga dianafulga linked a pull request Jan 16, 2024 that will close this issue
feat: Radio group implementation #73
Merged
@tselit
Copy link

tselit commented Jan 23, 2024

Addressed review comments & awaiting final review.

@github-project-automation github-project-automation bot moved this from In Review to Done in Web Monetization Extension Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dianafulga dianafulga

Labels
area: popup Improvements or additions to extension popup
Projects
Web Monetization Extension
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Radio group implementation interledger/web-monetization-extension
3 participants
@dianafulga @raducristianpopa @tselit