Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal testing: v1 #31

Open
lengyel-arpad85 opened this issue Nov 19, 2024 · 21 comments
Open

Internal testing: v1 #31

lengyel-arpad85 opened this issue Nov 19, 2024 · 21 comments
Assignees

Comments

@lengyel-arpad85
Copy link
Collaborator

Please add here any issue found regarding functionality, or if you have feature requests even typos or text changes you deem important!

V1 Banner features:

configurable background, text color & font
options for where to display (top | bottom) of host page, and option to animate
banner script also injects a monetization link with defined wallet address, i order to ensure that there is a link to test against to determine if user has WM extension or not
banner is only displayed if no monetization support detected
get extension link is auto generated based on browser and is pointing to the extensions page, in a non supported browser the link points to the webmonetization webpage
visitor has the option to close the banner, this is remembered for that session

V1 Widget features:

configurable background, text color & font
interledger pay is embeded as a payment solution
styles for ILPay are passed as parameters to make sure the ILPay matches the widget defined look

@lengyel-arpad85 lengyel-arpad85 self-assigned this Nov 27, 2024
@JoblersTune
Copy link

Small comments. The initial colour for the banner customization is not the best choice (pink) against the dark blue backdrop. Can't we show it defaulting to turquoise so that it's just a more visually appealing first impression?

And also in terms of the preset list of colours available for the widget, I'd only include colours in that preset list that compliment the logo. I'd argue orange for instance is not one of these colours. The turquoise causes the logo to all but disappear.

I'd love to get feedback from Madalina for instance.

And finally, I'm not seeing a button for the widget (see screenshot in case this is just a me thing). So there are customization options but I can't see how they look.
image

@JoblersTune
Copy link

Can we add a feature for text size? Maybe my eyes aren't the best (which they're not), but I find the Cookie font option illegible at that font size.

@JoblersTune
Copy link

In the WordPress plugin previously, we had an option for a margin around the banner and widget as well to customize not only the general location but added a bit more specificity. Maybe it's overkill? But adding it here just so that it's on your radar. The way people embed this in their sites, they'd probably be able to add the correct styling too, since we're assuming some technical skill, which does make this different from the WordPress case.

@lengyel-arpad85
Copy link
Collaborator Author

lengyel-arpad85 commented Nov 27, 2024

@JoblersTune if you click the circle w the logo in it (the trigger) it will display the entire widget, and you can see the effect of your chosen options

Screenshot from 2024-11-27 11-45-38

@lengyel-arpad85
Copy link
Collaborator Author

In the WordPress plugin previously, we had an option for a margin around the banner and widget as well to customize not only the general location but added a bit more specificity. Maybe it's overkill? But adding it here just so that it's on your radar. The way people embed this in their sites, they'd probably be able to add the correct styling too, since we're assuming some technical skill, which does make this different from the WordPress case.

In principle we assume user can copy-paste, so I'm quite open to adding additional settings into WM Tools editor to help the users who do not have any technical skills

@JoblersTune
Copy link

Error message colouring also needs consideration

image

@JoblersTune
Copy link

Could we expand the widget automatically when the user clicks Btn background?

@JoblersTune
Copy link

Is there a way to see the button as it would appear in an active state? It looks disabled to me here.

@JoblersTune
Copy link

For consistency, for the widget, I'd say

  1. either removing the rounding feature for the button
  2. Or add it for the input fields as well

Why customize one but not the other?

@lengyel-arpad85
Copy link
Collaborator Author

Is there a way to see the button as it would appear in an active state? It looks disabled to me here.

yes, set any value (by clicking one of the circles displaying the $ values)

@sidvishnoi
Copy link
Member

Banner should have a max width, and probably a larger font size:

image

@JoblersTune
Copy link

JoblersTune commented Nov 27, 2024

I also think we need clearer wording for the info sections

  1. Create banner -> "When a Web Monetization extension isn't detected, a banner will inform users that this site is Web Monetized. It will automatically include a browser-specific link to the extension. Messaging and styling are fully customizable to align with your site's look and feel."
  2. Create widget -> "This widget enables one-time payments for your website. It appears in the lower right corner, visible to all visitors regardless of their Web Monetization status. The title, text, and styling of the displayed message are customizable." Also I don't understand the part where it currently says "While preset values are set..." What presets?
  3. Wallet address -> "Your wallet address is required in order for us to save this component's configuration for you, link it to the original creator, and verify ownership for future updates. It also embeds the wallet address into your web page automatically, enabling Web Monetization on your behalf."

Questions

  1. What happens in cases where the extension is not installed - will the banner still display - I'm assuming yes
  2. What happens if the extension is there but inactive - I'm assuming the banner will still display. If the extension is present but inactive, wouldn't you still like your users to know that your site uses web monetization? E.g. what if they have an expired grant they haven't renewed. Or they ran out of funds in that account. Or they changed wallet addresses. Shouldn't we prompt based on inactivity to remind them to solve these issues? Something along the lines of "We are a web monetized site, if you wish to support us please enable your web monetization browser extension". This only applies if we can detect an inactive extension.
  3. Can we detect the presence of the extension if it's inactive?
  4. How is wallet address ownership verified? Or can I just make this for anyone's wallet address? Because that feels like an issue. If I'm spiteful I can change the text to something offensive and it will make live changes to the actual site owner's site, correct?

The current info wording only lists the inactive state but then the banner includes a link to the extension.

Suggestions

  • It would be nice for the banner preview to have a dismiss button on it so that you don't need to explain it is dismiss-able, it is visually obvious.

@JoblersTune
Copy link

The site should probably also link back to the Web Monetization docs as well.

@JoblersTune
Copy link

We need consistent wording so I think this should say "wallet address" not "payment pointer"
image

@JoblersTune
Copy link

I would find this wording annoying if I already had the extension "Future of support
Experience the new way to support our content. Activate Web Monetization in your browser and support our work as you browse. Every visit helps us keep creating the content you love! You can also support us by a one time donation using our solution below!"

Before we would have a monetized vs non-monetized messaging. So that way site owners can say thank rather than explaining things.

Also think we can improve on "You can also support us by a one time donation using our solution below!" Rather just say "You can also support us by a one time donation below!"

@lengyel-arpad85
Copy link
Collaborator Author

Questions

  1. What happens in cases where the extension is not installed - will the banner still display - I'm assuming yes
  2. What happens if the extension is there but inactive - I'm assuming the banner will still display. If the extension is present but inactive, wouldn't you still like your users to know that your site uses web monetization? E.g. what if they have an expired grant they haven't renewed. Or they ran out of funds in that account. Or they changed wallet addresses. Shouldn't we prompt based on inactivity to remind them to solve these issues? Something along the lines of "We are a web monetized site, if you wish to support us please enable your web monetization browser extension". This only applies if we can detect an inactive extension.
  3. Can we detect the presence of the extension if it's inactive?
  4. For the widget - does it only show when an active extension is detected? Or always. I'm assuming always. Since someone may have a wallet address without having the extension. Not everyone likes extensions.
  5. How is wallet address ownership verified? Or can I just make this for anyone's wallet address? Because that feels like an issue.
  1. yes, the banner is displayed
  2. yes, the banner is displayed if the extension is inactive (disabled from extensions), BUT no information leaves the extension (by design) so we do not have any way of detecting if recurring payments are setup, if there are funds available or even if the extension is configured
  3. no
  4. it always shows, it's suppose to be another way of providing payment solution for users who do not use the extension
  5. I had accounted for that, but it's not deployed yet: Request grant confirmation when updating existing config #13

@lengyel-arpad85
Copy link
Collaborator Author

The site should probably also link back to the Web Monetization docs as well.

it does for the browsers we do not recognize or do not support yet, instead of displaying the link to the store it uses the webmonetization.org link

@JoblersTune
Copy link

For the banner wording: What about "Want to support me?" "You can contribute with a one-time donation or pay automatically while you engage through the Web Monetization browser extension"

I think we also need a link here that explains to people what Web Monetization is and how they can go about getting a wallet address...

@lengyel-arpad85
Copy link
Collaborator Author

For the banner wording: What about "Want to support me?" "You can contribute with a one-time donation or pay automatically while you engage through the Web Monetization browser extension"

I think we also need a link here that explains to people what Web Monetization is and how they can go about getting a wallet address...

the text is fully customizable by the site owner using the tools configurator, or are you suggesting we update the default text ?

@JoblersTune
Copy link

For the banner wording: What about "Want to support me?" "You can contribute with a one-time donation or pay automatically while you engage through the Web Monetization browser extension"
I think we also need a link here that explains to people what Web Monetization is and how they can go about getting a wallet address...

the text is fully customizable by the site owner using the tools configurator, or are you suggesting we update the default text ?

Yes, I'm suggestion we update the default text.

@mkurapov
Copy link

mkurapov commented Nov 28, 2024

Small comments:

  • we should change the favicon of the site (currently remix default)
  • the "title" and "text" input sections should be together so its clear when adjusting the text (for banner)
  • nit: feels like some of the dropdowns don't necessarily need the ability to search/type for results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants