Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image type object only showing first image. #52

Closed
glenrobson opened this issue Jan 18, 2024 · 5 comments
Closed

Image type object only showing first image. #52

glenrobson opened this issue Jan 18, 2024 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@glenrobson
Copy link
Collaborator

Transfering from: ArchiveLabs/iiif.archivelab.org#137

The following item should have three images but only has one:

The logic in the app resolve right now only takes the last image in the file list and creates a manifest for that single image.

We'll need a way to check for multiple valid images, and then add those as canvases individually.

@glenrobson
Copy link
Collaborator Author

@digitaldogsbody you were right. The book reader returns

{
      "error": {
            "string": "Couldn't find image stack.",
            "itemid": "arkivkopia.se-lms-G70-48.3",
            "server": "ia800802.us.archive.org",
            "request_uri": "/BookReader/BookReaderJSIA.php?id=arkivkopia.se-lms-G70-48.3&itemPath=/1/items/arkivkopia.se-lms-G70-48.3&server=ia800802.us.archive.org&format=jsonp&subPrefix=arkivkopia.se-lms-G70-48.3"
      }
}

from: https://ia800802.us.archive.org/BookReader/BookReaderJSIA.php?id=arkivkopia.se-lms-G70-48.3&itemPath=/1/items/arkivkopia.se-lms-G70-48.3&server=ia800802.us.archive.org&format=jsonp&subPrefix=arkivkopia.se-lms-G70-48.3

@glenrobson
Copy link
Collaborator Author

Original files in object:

__ia_thumb.jpg format: 'Item Tile'
arkivkopia.se-lms-G70-48.3_files.xml format: 'Metadata'
arkivkopia.se-lms-G70-48.3_meta.sqlite format: 'Metadata'
arkivkopia.se-lms-G70-48.3_meta.xml format: 'Metadata'
original_lms2_4c4d535f4737302d34383a33.index.1.tiff.jpg format: 'JPEG'
original_lms2_4c4d535f4737302d34383a33.index.2.tiff.jpg format: 'JPEG'
original_lms2_4c4d535f4737302d34383a33.index.3.tiff.jpg format: 'JPEG'

Maybe use count(format in valid_filetypes) > 1

@digitaldogsbody
Copy link
Collaborator

@digitaldogsbody you were right. The book reader returns

{
      "error": {
            "string": "Couldn't find image stack.",
            "itemid": "arkivkopia.se-lms-G70-48.3",
            "server": "ia800802.us.archive.org",
            "request_uri": "/BookReader/BookReaderJSIA.php?id=arkivkopia.se-lms-G70-48.3&itemPath=/1/items/arkivkopia.se-lms-G70-48.3&server=ia800802.us.archive.org&format=jsonp&subPrefix=arkivkopia.se-lms-G70-48.3"
      }
}

from: https://ia800802.us.archive.org/BookReader/BookReaderJSIA.php?id=arkivkopia.se-lms-G70-48.3&itemPath=/1/items/arkivkopia.se-lms-G70-48.3&server=ia800802.us.archive.org&format=jsonp&subPrefix=arkivkopia.se-lms-G70-48.3

It occurs to me there is a situation where this might not occur - if there is a file called <identifier>_images.zip then the BookReader may well find an "image stack" regardless of the mediatype in the metadata (based on Hank's comment here rather than any testing).

I think it won't affect us if we go with the counting of originals with valid formats you outlined above, but we should be aware of it for items such as mareful which have multiple book stacks (#12).

@glenrobson
Copy link
Collaborator Author

Can this be closed?

@glenrobson
Copy link
Collaborator Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants