심화테이블 뷰 구현 완료 & 음악 검색앱 구현 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eogus4658
reviewed
May 23, 2024
|
|
||
| import UIKit | ||
|
|
||
| class AddMemberViewController: UIViewController{ |
There was a problem hiding this comment.
더 이상 상속되지 않는 클래스에는 final 키워드 붙여주는 게 좋아!
eogus4658
reviewed
May 23, 2024
Comment on lines
+33
to
+37
| extension UITableViewCell { | ||
| static var identifier: String { | ||
| return String(describing: self) | ||
| } | ||
| } |
There was a problem hiding this comment.
UITableViewCell Extension 파일을 따로 분리하는 게 더 좋을 것 같아!
There was a problem hiding this comment.
아 나는 같은 Cell 파일에 있어야 하는줄 알았다..!! 그럼 컨트롤러 쪽으로 옮길게!
eogus4658
reviewed
May 23, 2024
Comment on lines
24
to
25
| let image = UIImage(data: data) | ||
| musicImage.image = image |
There was a problem hiding this comment.
지금 Task 안에서 비동기로 작동하는 코드 안에서 ui 수정을 할 때에는 메인 쓰레드에서 적용하는 게 안전해! 메인 쓰레드와 글로벌 쓰레드의 차이점, DispatchQueue 키워드 참고해서 알아봐도 좋을 것 같아!
There was a problem hiding this comment.
DispatchQueue를 자세히 못봤던 것 같아! ui수정은 메인쓰레드레서 해야하니까 Dispatchqueue.main.async를 사용하는게 맞는거지?
수정해서 올릴게!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #15
close #20
구현 완료