-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request: dynamic runPubGetInParallel #546
Comments
I would also add that the current default value of true can cause a lot of headaches for everyone who starts using melos and starts running into issues on the CI as the errors caused by parallel pub get runs at first glance seem to have nothing to do with melos. This "auto" option could be the default option solving the above problem elegantly. |
It sounds like a good idea, if anyone is keen on implementing it, feel free to submit a PR. :) |
@spydon I was thinking about this issue. The reason we want a flag like this is the fact that on CI machines melos seem to get into weird race conditions during running I think this is what should be fixed. Adding this auto flag is like accepting this as a fact, like it was anticipated to have issues on CI. |
If you want to investigate it, feel free, I haven't been able to come to any conclusions about when it is failing and when it is not (it works most of the time). Once the workspace feature lands I'm sure this won't be a problem anymore: http://flutter.dev/go/pub-workspace |
Is there an existing feature request for this?
Command
No response
Description
The flag runPubGetInParallel should accept:
true
false
auto
The option "auto" would fallback to false when the machine is a CI instance. This can be checked with the environment variable
CI
Resources:
CI
built-in variableCI
built-in variableCI
built-in variableReasoning
Locally, running pub get in parallel is very useful and not at all prone to resulting in a broken pubspec.lock. On CI processes, however, it can break easily. Modifying this manually is very annoying.
Additional context and comments
No response
The text was updated successfully, but these errors were encountered: