Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errorhandling with check.js #2306

Open
mcm1957 opened this issue May 20, 2023 · 1 comment
Open

Errorhandling with check.js #2306

mcm1957 opened this issue May 20, 2023 · 1 comment
Assignees
Labels

Comments

@mcm1957
Copy link
Collaborator

mcm1957 commented May 20, 2023

Check.js script fails if the sources-dist-*.json is invalid, even if it has been corrected at a later commit within the PR:

adapters filtered:
imap
---
SyntaxError: Unexpected string in JSON at position 49635
    at JSON.parse (<anonymous>)
    at detectChanges (/home/runner/work/ioBroker.repositories/ioBroker.repositories/lib/check.js:144:23)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async detectAffectedAdapter (/home/runner/work/ioBroker.repositories/ioBroker.repositories/lib/check.js:159:29)
    at async doIt (/home/runner/work/ioBroker.repositories/ioBroker.repositories/lib/check.js:270:19)

I would suggest:
-) to add more infos to the exception, i.e. filename
-) log the data (if possible and usable - to be checked)
-) abort this co mit but continue with the next commit.

In general its NOT the job of check.js to verify the correct syntax of the sources-*.json files. There are other jobs doing this anyway. So it should nozt be a problem to skip this error / skip this commit.

(I can take care of this when time is available).

@mcm1957 mcm1957 self-assigned this May 20, 2023
@mcm1957 mcm1957 changed the title Errorthandling with check.js Errorhandling with check.js May 20, 2023
@mcm1957 mcm1957 added the bug label May 28, 2023
@mcm1957
Copy link
Collaborator Author

mcm1957 commented May 28, 2023

see #807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant