Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider fixing issues detected by repository checker #207

Open
2 of 10 tasks
ioBroker-Bot opened this issue Sep 11, 2024 · 4 comments
Open
2 of 10 tasks

Please consider fixing issues detected by repository checker #207

ioBroker-Bot opened this issue Sep 11, 2024 · 4 comments

Comments

@ioBroker-Bot
Copy link

ioBroker-Bot commented Sep 11, 2024

Notification from ioBroker Check and Service Bot

Dear adapter developer,

I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter samsung for common errors and appropiate suggestions to keep this adapter up to date.

This check is based the current head revisions (master / main branch) of the adapter repository

Please see the result of the check below.

ioBroker.samsung

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release

👍 No errors found

WARNINGS:

  • 👀 [W034] @iobroker/adapter-core 3.2.1 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json
  • 👀 [W043] dependency should not require a github version. Please change "samsungtv:https://[email protected]/luca-saggese/samsungtv"
  • 👀 [W047] dependency should not require a specific version. Use "~1.2.3" or "^1.2.3" syntax. Please update "node-fetch:2.6.7"
  • 👀 [W113] Adapter should support compact mode
  • 👀 [W113] Please test whether adapter can support compact mode, if not set "common.compact:false" at io-package.json
  • 👀 [W168] "common.keywords" should not contain "iobroker, adapter, smart home" io-package.json
  • 👀 [W173] Potential sensitive data "token,pin" not listed at "protectedNative" in io-package.json
  • 👀 [W174] Potential sensitive data "token,pin" not listed at "encryptedNative" in io-package.json
  • 👀 [W953] .npmignore found - consider using package.json object "files" instead.

SUGGESTIONS:

  • 📌 [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.

Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.

Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.

You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:

@iobroker-bot recheck
or
@iobroker-bot recreate

Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.

Feel free to contact me (@ioBroker-Bot) if you have any questions or feel that an issue is incorrectly flagged.

And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.

your
ioBroker Check and Service Bot

@mcm1957 for evidence

Last update at Fri, 01 Nov 2024 05:34:11 GMT based on commit 6963c46
ioBroker.repochecker 3.1.4

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[E955] iob_npm.done not found in .npmignore

👍Thanks for fixing the issues.

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[W168] "common.keywords" should not contain "iobroker, adapter, smart home" io-package.json

👍Thanks for fixing the issues.

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[W113] Adapter should support compact mode

👍Thanks for fixing the issues.

The following issues are new and have been added
[W113] Please test whether adapter can support compact mode, if not set "common.compact:false" at io-package.json

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues are new and have been added
[W034] @iobroker/adapter-core 3.2.1 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant