Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - modal is fixed at top of page and displays improperly for long page #13

Open
anotherhale opened this issue Jan 16, 2021 · 1 comment

Comments

@anotherhale
Copy link
Collaborator

Elm.modal.1.mp4

Thinking about allowing the opening, opened, closing, and closed CSS functions to be configurable so that the client can provide their own CSS functions to resolve this issue.

@ondrej-tucek
Copy link
Contributor

ondrej-tucek commented Jan 16, 2021

Thanks a lot for this bug Andy. We totally overlooked it. Yes it could be possible. I think that we need some default setting anyway.

I just looked at the code and there is

  1. a function modalFade: maybe it would be better here to remove Css.position, Css.top, Css.bottom, Css.left, Css.right and try to add something like Css.width (Css.vw 100) and Css.height (Css.vh 100)
  2. a function setBodyFromTop which could help with some function to getting "viewport offset y position". Not sure if this getViewportOf could save us..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants