fix(compiler) restore old copy behaviour, with new ignore option #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMTHD
approved these changes
Oct 9, 2024
|
we encounter copy problems with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
#5899 introduced a lot of regressions:
A breaking change in copy behavior: #5983
file to file copying broken: #5956
EBUSY: resource busy: #5966
Directories from above the root dir are copied outside of the output dir.
What is the new behavior?
This PR restores the old copy behavior, but uses the passed filter list, rather than the hardcoded one.
This isn't an optimum fix, as it changes the copy back to
dirtodir(orfiletofile), so ignore patterns aren't matched against child files. Only glob matches are ignored (as was the previous behavior). IMO it's better than the large number of regressions, especially as this can now be worked around (e.g. in the case of #5781) by the user moving to a glob copy, with the new ignore option.Documentation
none
Does this introduce a breaking change?
Testing
Tested on own repo.
Other information
fixes: #5983
fixes: #5956
fixes: #5966