fix(types): add controlslist to html declarations #6026
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prior to this commit, using the `controlslist` attribute in a `video` or `audio` element would result in a type checking error. with this commit, we allow the attribute to take one of three values: - nodownload - nofullscreen - noremoteplayback note that at the time of this writing, only chromium browsers support this attribute. it is the responsibilty of end users to determine if using this attribute is appropraite for their projects. fixes: ionic-team#6015
|
Just passing through the old neighborhood 😉 |
|
BTW, I no longer have merge permissions, so I'll leave this y'all to merge when it's time |
christian-bromann
approved these changes
Oct 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
prior to this commit, using the
controlslistattribute in avideooraudioelement would result in a type checking error. with this commit, we allow the attribute to take one of three values:What is the new behavior?
note that at the time of this writing, only chromium browsers support this attribute. it is the responsibilty of end users to determine if using this attribute is appropraite for their projects.
Documentation
Does this introduce a breaking change?
Testing
Adding a
videooraudioelement to a stencil component like so no longer creates type errors:Other information
fixes: #6015