New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArchFxStreamSlug cannot handle an empty parent #1

Open

dkarchmer opened this issue Oct 26, 2020 · 0 comments

Contributor

dkarchmer commented Oct 26, 2020

A few tests that set the parent as '' or None are failing. e.g.

https://github.com/iotile/python_archfx_cloud/blob/main/tests/test_slugs.py#L147

Need to fix that and reenable those tests. Passing '' or None should be equivalent to passing a 0 and should represent pl--0000-0000

Note that we may have fixed that already on archfx_cloud: https://github.com/iotile/archfx_cloud/blob/master/server/apps/utils/gid/slugs.py

so need to diff with that file and update as needed. Once we deploy, the archfx_cloud should be replaced with this package

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment