Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember 2.12 deprecation warning #3

Open
no-mercy opened this issue Mar 31, 2017 · 1 comment
Open

Ember 2.12 deprecation warning #3

no-mercy opened this issue Mar 31, 2017 · 1 comment

Comments

@no-mercy
Copy link

Ember will stop passing arguments to component lifecycle hooks. Please change <app@component:trumbowyg-editor::ember1196>#didUpdateAttrs to stop taking arguments.

Trouble is in didUpdateAttrs method, which should be aligned with new requirements:
https://emberjs.com/deprecations/v2.x/#toc_arguments-in-component-lifecycle-hooks
@bradleypriest
Copy link

Suggested fix here #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradleypriest @no-mercy