You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to make it clear whether the emitter is simply closed (and the sender should go away) or something actually went wrong.
Really, we should probably just log what went wrong and return a boolean where false means "closed". Currently, we return an error but it's unclear how this error should be handled. Should the caller follow up with a SetError call? (the answer is no but the API is really unclear).
Also, we need to make sure that all emitters handle context cancellation correctly.
The text was updated successfully, but these errors were encountered:
We need to make it clear whether the emitter is simply closed (and the sender should go away) or something actually went wrong.
Really, we should probably just log what went wrong and return a boolean where
false
means "closed". Currently, we return an error but it's unclear how this error should be handled. Should the caller follow up with aSetError
call? (the answer is no but the API is really unclear).Also, we need to make sure that all emitters handle context cancellation correctly.
The text was updated successfully, but these errors were encountered: