You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should always construct requests with the NewRequest function and should handle everything like CheckArguments there. Currently, we end up calling CheckArguments multiple times and have to defend against this. Bleh.
The text was updated successfully, but these errors were encountered:
It's actually worse. I've fixed the double check here but we also check in cli's parseArgs function. However, we do so with completely different logic (and without blocking on stdin).
Really, we should do this in stages:
Parse but don't check. Unfortunately, we still need access to the tree of commands to distinguish between arguments and subcommands.
Handle help (before checking anything else).
Check options and arguments.
This should also allow us to deduplicate some of this functionality.
We should always construct requests with the
NewRequest
function and should handle everything likeCheckArguments
there. Currently, we end up callingCheckArguments
multiple times and have to defend against this. Bleh.The text was updated successfully, but these errors were encountered: