Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium: prompt user to approve protocol handler registration #1128

Open
lidel opened this issue Jan 12, 2023 · 4 comments
Open

Chromium: prompt user to approve protocol handler registration #1128

lidel opened this issue Jan 12, 2023 · 4 comments
Labels
area/chromium Issues related to Chromium-based browsers effort/days Estimated to take multiple days, but less than a week kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented Jan 12, 2023

Firefox supports preregistration of handlers via protocol_handlers in webextension Manifest, but Chromium does not:

(github) The title of the Chromium issue was confusing, so to clarify: https://bugs.chromium.org/p/chromium/issues/detail?id=64100#c59 ; basically the owner of the extension code had concerns about the approach with protocol_handler in the manifest and what ended up being implemented in Chrome is giving special power to registerProtocolHandler in web extensions.

Talked with Igalia today, and we will ask Google to reconsider protocol_handlers support in Chromium: landscape is bit different, Microsoft Edge's improves the way PWA and we may find alignment / deduplication of efforts around this.

That being said, these things take way more time that we initially anticipated, so it may be useful to implement a stop-gap solution, as protocol_handlers ETA in Chromium is unknown.

First, understand what is possible

https://bugs.chromium.org/p/chromium/issues/detail?id=64100 is unclear if 3) Allowing extensions to redirect to a third-party domain (instead of chrome-extension://<id>/...) was implemented.

My suggestion is to make a PoC first that tries to register handler via registerProtocolHandler from browser extension's background page:

  1. https://dweb.link/ipfs/?uri=%s
  2. chrome-extension://<id>/dist/router.html#uri=%s

This will inform our next step.

Ideally, we would point at (1), if we can't then we would create a router page (2) which has JS that reads URI from window.location.hash and performs window.location.replace to the correct destination.

Proposed implementation

  • Create utility function that checks if ipfs:// and ipns:// handlers are registered via registerProtocolHandler, and if not, attempt to register a handler.

    • If possible, we want to register a public gateway as a handler (https://dweb.link/ipfs/?uri=%s).
      This way it works when local node is off or redirect is disabled, IPFS URIs still resolve, but we need to work with whatever is actually possible in Chromium.
  • When user installs IPFS Companion OR toggles global redirect, we run the check again.

    • This should be good enough to ensure user has opportunity to approve handler registration via user gesture if they missed this after initial install.

cc @autonome @whizzzkid ipfs/in-web-browsers#168 #164

@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up area/chromium Issues related to Chromium-based browsers need/triage Needs initial labeling and prioritization need/analysis Needs further analysis before proceeding effort/days Estimated to take multiple days, but less than a week labels Jan 12, 2023
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Jan 13, 2023
@lidel
Copy link
Member Author

lidel commented Jan 23, 2023

Discussed this with Javier from Igalia and we should be able to trigger registation of handler that points at dweb.link because our host_permissions are broad enough.

The caveat is that registerProtocolHandler can't be called from service worker, and we need to open HTML in a new tab – let's try reusing our existing post-install welcome page for this.

@whizzzkid this is not blocked by MV3, we could do this in MV2 – code remains the same. Will you have time to give this a try before digging deep into MV3?

@lidel lidel removed need/triage Needs initial labeling and prioritization need/analysis Needs further analysis before proceeding labels Jan 23, 2023
@lidel
Copy link
Member Author

lidel commented Feb 9, 2023

Note from meeting with Igalia

  • we need this as a PoC to demonstrate downsides of the UX proposed by Chromium maintainers, and argue for better approach
  • if handler is missing, prompting user every time peerCount > 0 is a good way to demonstrate how annoying this API is

@SgtPooki
Copy link
Member

@lidel
Copy link
Member Author

lidel commented Mar 17, 2023

also related: #164 (comment) (no ETA, so this issue remains useful and open).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chromium Issues related to Chromium-based browsers effort/days Estimated to take multiple days, but less than a week kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

2 participants