-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MV3] Firefox RPC access broken due to CORS #1244
Comments
assigned to @whizzzkid |
@whizzzkid one thing you could try is to register a separate, synchronous ps. worst case, if we can't make it work, we need to be pragmatic, given the browser market share and the fact MV2 works just fine: if you see there is too much work to make it work, we could keep Firefox on MV2 for now (create |
@lidel well actually I did not face it (to begin with), upon further investigation, it's a bit more nuanced, the culprit is the new Requesting permissions is also now a cumbersome process, the browser won't let us raise a request to grant perms from any script, it needs to explicitly come from a Creating: #1250 |
Closed with #1250 |
Something broke RPC API access in Firefox, requests get blocked by CORS, which suggests the Origin HTTP header override we do here no longer does its job and access to RPC port is not safelisted correctly.
My gut feeling is the cause is switching
onBeforeRequest
toasync
, but there could be other reason.The text was updated successfully, but these errors were encountered: