-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPFS Desktop/WebUI stop loading when turn wifi off #2492
Comments
Thanks for submitting this issue @momack2, I tried reproducing the issue but that does not happen, I am able to browse the content of my local node just as I would when connected to wifi. I wonder if this issue related to a specific file or size of the storage. To be able to reproduce this, can you please:
Thanks! |
Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days. |
There are some cases where data in MFS is a shallow reference (the bottom of wikipedia mirror wiki references how to do this). There are other issues in this repo that have discussed whether we should fully resolve CIDSs locally or not, and that we should provide a UI indicator showing users whether content is actually downloaded or not. Self Todo: |
Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days. |
This issue was closed because it is missing author input. |
I was unable to reproduce this just by disabling wifi. I was able to reproduce this by following the steps in ipfs/ipfs-webui#1691 Steps I followed:
Closing this in favor of ipfs/ipfs-webui#1691 & ipfs/ipfs-webui#961 Other related issues: |
@SgtPooki another thing one could try here is to check if macOS wifi status is reflected on If so, webui could register listener to online/offline state change, and modify behavior around items which are not 100% local (e.g. grey them out, set shorter timeout + more meaningful message etc). Checking what % of data is local could be expensive, but the result can be cached per CID until the online/offline status changes. > ipfs files stat --with-local /ipfs/QmTyS43Vbwht5LE8bvPP4nZmWYyc7iafweD6zJhJhGmAJa
QmTyS43Vbwht5LE8bvPP4nZmWYyc7iafweD6zJhJhGmAJa
Size: 0
CumulativeSize: 27932070
ChildBlocks: 29
Type: directory
Local: 980 kB of 28 MB (3.51%) |
@lidel that sounds like a 🩹 band-aid fix, I wonder if this should be handled by kubo, i.e. the client (in this case webui) should not be figuring this out. If the network is an issue, the status should be reported as such? |
Maybe? But doing this desktop-specific thing in Kubo (which is used outside of desktop use cases too) is tricky. From the Kubo perspective, there are other network interfaces than Wifi still working (loopback, VPNs, overlay networks). User could be running more than one node on the same machine, and they would still work and exchange data with each other. Kubo would need to maintain some code that tests/decides what is "online" and what is "offline", and if this is slightly different for macOS and Windows, we run into a lot of maintenance cost for something that is already implemented and tested by web browser. What Kubo could do, tho, is to do very simple thing: detect when request for new data (that is not cached locally) occurs when no peers are available, and return some canonical error instead of waiting for new peers to appear. |
@lidel this issue is still closed, because a lot of the work for resolving this will be in ipfs-webui, but I created ipfs/ipfs-webui#2135 to consolidate work for addressing all of the issues affecting the experience that caused the filing of this issue. let's continue any further discussion there. |
Describe the bug
When I try to load the IPFS Desktop webui when I turn wifi off, the files I have stored on my local IPFS node no longer load (but load fine again when wifi is re-enabled)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I should be able to fully browse my local IPFS files even when I'm offline
The text was updated successfully, but these errors were encountered: