Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing/incorrect specification for how blocks are stored in the repo #8739

Open
2 tasks done
aschmahmann opened this issue Feb 16, 2022 · 0 comments
Open
2 tasks done
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful P2 Medium: Good to have, but can wait until someone steps up topic/docs-ipfs Topic docs-ipfs

Comments

@aschmahmann
Copy link
Contributor

Checklist

Location

No response

Description

Currently the only documentation I'm aware of that explains the layout of the go-ipfs repo, and in particular the blockstore, is README that lives inside of FlatFS repos https://github.com/ipfs/go-ds-flatfs/blob/f0750204617b5b0cfb414c38ce486bf9f01963bb/readme.go.

Not only is that the wrong place to put that documentation (since some of it applies regardless of the backing datastore), but it's also incorrect post v0.12.0 and the CID -> multihash migration for the blockstore. We should put a doc in this repo that explains at the very least the blockstore layout if not more generally the repo.

Some of this information lives in ipfs/specs currently although that seems to be the wrong place as it is implementation specific. Examples include https://github.com/ipfs/specs/blob/master/REPO.md and https://github.com/ipfs/specs/blob/master/REPO_FS.md. These may also be very out of date.

Some repo behavior might belong in ipfs/specs (e.g. the API file and corresponding environment variables, or things like #8847), but probably not all of it.

@aschmahmann aschmahmann added topic/docs-ipfs Topic docs-ipfs need/triage Needs initial labeling and prioritization effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful P2 Medium: Good to have, but can wait until someone steps up topic/docs-ipfs Topic docs-ipfs
Projects
None yet
Development

No branches or pull requests

1 participant