Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract and encapsulate gateway checking logic from this package and JayBrown/Tools/tree/master/ipfg #192

Open
SgtPooki opened this issue Mar 2, 2022 · 3 comments
Labels
effort/weeks Estimated to take multiple weeks kind/maintenance Work required to avoid breaking changes or harm to project's status quo P3 Low: Not priority right now topic/cd Continuous Deployment topic/ci Continuous integration

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Mar 2, 2022

In the readme, we state:

A CLI version ipfg is available here: https://github.com/JayBrown/Tools/tree/master/ipfg

I propose we encapsulate the logic in this repo into its own encapsulated logic so that one could run the check in both the browser and via CLI, but also via other packages.

It would also make sense to support the often requested "gateway race" logic within this package.

@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Mar 2, 2022
@welcome

This comment was marked as resolved.

@SgtPooki
Copy link
Member Author

SgtPooki commented Mar 2, 2022

@lidel thoughts?

@lidel
Copy link
Member

lidel commented Apr 4, 2022

SGTM.

I will be writing HTTP Gateway specs, and want to have a compliance test suite for HTTP gateway that tests against that spec.

Some tests are really easy to do outside of browser, so I am not sure if we will have 100% code resuse, but even if we could have 80% of code that can run in both browser and CI that is a big win.

First step would be to extract logic and run tests on GithubAction CI, testing PRs submitted against this repo and failing if gateway is offline or does not support IPNS.

@lidel lidel added P3 Low: Not priority right now kind/maintenance Work required to avoid breaking changes or harm to project's status quo and removed need/triage Needs initial labeling and prioritization labels Apr 4, 2022
@SgtPooki SgtPooki self-assigned this Jun 8, 2022
@SgtPooki SgtPooki added topic/ci Continuous integration topic/cd Continuous Deployment effort/weeks Estimated to take multiple weeks labels Jul 13, 2022
@SgtPooki SgtPooki removed their assignment Sep 22, 2022
@SgtPooki SgtPooki moved this from Needs Grooming to Planned / Backlog in IPFS-GUI (PL EngRes) Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/weeks Estimated to take multiple weeks kind/maintenance Work required to avoid breaking changes or harm to project's status quo P3 Low: Not priority right now topic/cd Continuous Deployment topic/ci Continuous integration
Projects
No open projects
Status: Planned / Backlog
Development

No branches or pull requests

2 participants