Any chance of moving to js-sha3?

[daviddias]

Currently, this module brings in a Native dep [email protected]. Would it be possible to move to js-sha3, the same used in js-multihashing-async, so that it doesn't represent a blocker for js-ipfs electron users

> [email protected] install /Users/koruza/code/js-ipld-eth-star/node_modules/fsevents
> node install

[fsevents] Success: "/Users/koruza/code/js-ipld-eth-star/node_modules/fsevents/lib/binding/Release/node-v51-darwin-x64/fse.node" is installed via remote

> [email protected] install /Users/koruza/code/js-ipld-eth-star/node_modules/sha3
> node-gyp rebuild

  CXX(target) Release/obj.target/sha3/src/addon.o
../src/addon.cpp:59:36: warning: 'NewInstance' is deprecated [-Wdeprecated-declarations]
                        info.GetReturnValue().Set(cons->NewInstance(argc, argv));
                                                        ^
/Users/koruza/.node-gyp/7.10.0/include/node/v8.h:3658:31: note: 'NewInstance' has been explicitly marked deprecated
      here
                Local<Object> NewInstance(int argc, Local<Value> argv[]) const);
                              ^
1 warning generated.
  CXX(target) Release/obj.target/sha3/src/displayIntermediateValues.o
  CXX(target) Release/obj.target/sha3/src/KeccakF-1600-reference.o
  CXX(target) Release/obj.target/sha3/src/KeccakNISTInterface.o
  CXX(target) Release/obj.target/sha3/src/KeccakSponge.o
  SOLINK_MODULE(target) Release/sha3.node

> [email protected] install /Users/koruza/code/js-ipld-eth-star/node_modules/keccak
> prebuild-install || node-gyp rebuild || echo "Keccak bindings compilation fail. Pure JS implementation will be used."

Thanks!

[daviddias]

@kumavis ping

[kumavis]

@diasdavid This is set up so that you get the js implementation when targeting the browser, and c++ on node (with failover to js). So is there some error with the failover when targeting electron?

[kumavis]

echo "Keccak bindings compilation fail. Pure JS implementation will be used."

[daviddias]

I'm still investigating, but as far as I understand electron-rebuild is not super friendly to deps in Node.js that fail. It doesn't work well with the failover.