Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass file name into SubstraitPB import. #839

Open
ingomueller-net opened this issue May 30, 2024 · 0 comments
Open

Pass file name into SubstraitPB import. #839

ingomueller-net opened this issue May 30, 2024 · 0 comments

Comments

@ingomueller-net
Copy link
Collaborator

ingomueller-net commented May 30, 2024 •
edited
Loading

Could we do better here?  even just file name

I think yes, but this would require some code reorganization. A few notes before I forget: I'd need to implement the translation using llvm::SourceMgr and access BufferBuffer:: getBufferIdentifier to get the filename.

Originally posted by @ingomueller-net in #825 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ingomueller-net