Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve solution for #218 #225

Open
SwooshyCueb opened this issue Aug 23, 2024 · 3 comments
Open

Improve solution for #218 #225

SwooshyCueb opened this issue Aug 23, 2024 · 3 comments
Assignees

Comments

@SwooshyCueb
Copy link
Member

The current solution for #218, while fine, could use some improvement. It would be nice to migrate from a thread state based approach to a GIL state based approach, and to implement temporary/early unlocking of the GIL.

@korydraughn
Copy link
Contributor

What are the benefits of moving to a GIL state based approach?
Are there any downsides?

@SwooshyCueb
Copy link
Member Author

SwooshyCueb commented Aug 23, 2024

I've done a lot of timing tests and a GIL state based approach is significantly faster when it comes to nested locking, especially in older versions of python, but has more or less the same performance in other scenarios. In my testing I haven't found any downsides (yet).

@korydraughn
Copy link
Contributor

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants