Skip to content
This repository has been archived by the owner on May 16, 2019. It is now read-only.

No Findjansson.cmake for -DHUNTER_ENABLED=0 #1

Open
ringerc opened this issue Jun 5, 2018 · 5 comments
Open

No Findjansson.cmake for -DHUNTER_ENABLED=0 #1

ringerc opened this issue Jun 5, 2018 · 5 comments

Comments

@ringerc
Copy link

ringerc commented Jun 5, 2018

Maybe the CMake config file is bundled in Debian, or in a newer CMake release?

I'll submit one if needed, just figured I'd check if there's something I'm missing first.

$ cmake -DHUNTER_ENABLED=0 .
... blah ...
CMake Error at CMakeLists.txt:109 (find_package):
  By not providing "Findjansson.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "jansson", but
  CMake did not find one.

  Could not find a package configuration file provided by "jansson" with any
  of the following names:

    janssonConfig.cmake
    jansson-config.cmake

  Add the installation prefix of "jansson" to CMAKE_PREFIX_PATH or set
  "jansson_DIR" to a directory containing one of the above files.  If
  "jansson" provides a separate development package or SDK, be sure it has
  been installed.
$ rpm -ql jansson-devel
/usr/include/jansson.h
/usr/include/jansson_config.h
/usr/lib64/libjansson.so
/usr/lib64/pkgconfig/jansson.pc

$ rpm -q jansson-devel
jansson-devel-2.11-1.fc27.x86_64

$ cmake --version
cmake version 3.10.1
@ringerc
Copy link
Author

ringerc commented Jun 5, 2018

Case sensitivity issue, I guess you dev on a Mac? Sending a pull soon.

Similar issues with protobuf-c, but something different with pgc.

@ringerc
Copy link
Author

ringerc commented Jun 5, 2018

Why is pgc_random even necessary? Any decent OS should offer sensible pseudo-random number generation. Would you accept a patch to make that optional? I'll assume so and add it to my pull.

@ringerc
Copy link
Author

ringerc commented Jun 5, 2018

I'll address the random topic separately.

@isaachier
Copy link
Owner

Ya I have been focusing on development at the moment more than the lib modules etc. Will have to look into this more.

ringerc added a commit to 2ndQuadrant/jaeger-client-c that referenced this issue Jun 11, 2018
There were a number of case sensitivity issues in the CMake files relating
to differing case between the Hunter files and the ones in cmake/ (isaachier#1)

Also fixes finding of the protocol buffers support when protobuf 1.2 is
present (isaachier#4)
@ringerc
Copy link
Author

ringerc commented Jun 12, 2018

Fixed in PR #3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants