Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing of Error message for users inserting javascript #1118

Open
jacksonOGP opened this issue Oct 14, 2022 · 5 comments
Open

Changing of Error message for users inserting javascript #1118

jacksonOGP opened this issue Oct 14, 2022 · 5 comments
Labels
error message Error message modal in CMS

Comments

@jacksonOGP
Copy link

When users insert Javascript codes into Isomer CMS editor. A modal will pop up upon saving the page. (see ss)

image

The modal message is too technical.

Sample message here

Warning
There is unauthorised JS detected in the following snippets:

1:www.canva.com/design/daegaflmdhw/view?embed""
2:http:

Before saving, the editor input will be automatically sanitised to prevent security vulnerabilities.
To save the sanitised editor input, press Acknowledge. To return to the editor without sanitising, press Cancel.`

IMO i don't think we should explain to users in this manner, it should be something like

"Javascript inserted (as shown below) will be removed due to xyz reason"

@jacksonOGP jacksonOGP added the error message Error message modal in CMS label Oct 14, 2022
@jacksonOGP
Copy link
Author

jacksonOGP commented Oct 14, 2022

https://isomer.zendesk.com/agent/tickets/1299

ticket for my own reference

@seaerchin
Copy link
Contributor

seaerchin commented Oct 17, 2022

@NatMaeTan - i think jackson has a point here; should we clarify this w/ shanty? separately, i think we want to make clear that this is removed for security reasons (so that untrusted sources can't execute arbitrary code)

fyi @kathleenkhy

@kathleenkhy
Copy link

Can we put something like:

There is unauthorised Javascript code detected :

1:www.canva.com/design/daegaflmdhw/view?embed""
2:http:

The unauthorised Javascript inserted will be removed for security reasons

@NatMaeTan
Copy link
Contributor

@jacksonOGP the zendesk ticket didnt seem to mention about this modal message, but the error message in the preview instead.

image

But also agree that the error message modal is still v technical, think we could say smth like "The following unauthorised Javascript code must be removed before saving for security reasons." Then the buttons could be "Back to editor | Remove code"

@jacksonOGP
Copy link
Author

oops sorry the zesndesk ticket is for my own reference, yall can just refer to the screenshot lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error message Error message modal in CMS
Projects
None yet
Development

No branches or pull requests

4 participants