Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add workload selector for generated SEs for better load balancing across pods #140

Open
aattuluri opened this issue Aug 31, 2020 · 2 comments
Open

[FEATURE] Add workload selector for generated SEs for better load balancing across pods #140

aattuluri opened this issue Aug 31, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone
Nebulous Future

Comments

@aattuluri
Copy link
Contributor

Context
Currently, admiral generated SEs point to K8s service names which causes:
i) Istio subset routing to not work
ii) The load balancing doesn't work which impacts protocols like gRPC since the source pods do not directly connect to the destination pods but the clusterIps of the servic as admiral generated SE points to k8s service endpoint.

Proposed solution
Istio 1.6 and higher provides:
i) A new CR called WorkloadEntry
ii) WorkloadSelector on SE to reference the WorkloadEntry

Using these constructs, the SE generated with the local k8s service name can be replaced with a WorkloadEntry and a WorkloadSelector with appropriate labels to deliver the right EDS.
@aattuluri aattuluri added the enhancement New feature or request label Aug 31, 2020
@aattuluri aattuluri added this to the v1.1 milestone Aug 31, 2020
@aattuluri
Copy link
Contributor Author

istio/istio#25898

@aattuluri aattuluri modified the milestones: v1.1, v1.2 Sep 2, 2020
@aattuluri
Copy link
Contributor Author

We found that using headless services (clusterIp: None) will solve the problem of load balancing across pods. We will be deferring the support for workload entry until it graduates with all the bug fixes resolved. Refer to this comment for more information.

@benchi benchi modified the milestones: v1.2, v1.3 Nov 23, 2020
@aattuluri aattuluri modified the milestones: v1.3, Nebulous Future Apr 20, 2022
itsLucario pushed a commit to itsLucario/admiral that referenced this issue Aug 9, 2022
@aattuluri
Enhance checks for potential nil references (istio-ecosystem#241) (is…
de341d6 
…tio-ecosystem#140)

Co-authored-by: aattuluri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Nebulous Future
Development

No branches or pull requests
2 participants
@benchi @aattuluri