Upgrade dependency "github.com/argoproj/argo-rollouts"

[Ben131-Go]

Background

Repo github.com/istio-ecosystem/admiral depends on github.com/argoproj/[email protected].

https://github.com/istio-ecosystem/admiral/blob/master/go.mod#L6

However, comparing version v1.2.1 of github.com/argoproj/argo-rollouts from proxy.golang.org and github, there are inconsistencies.

commit time of the copy on github.com

"committer": {
      "name": "Jesse Suen",
      "email": "[email protected]",
      "date": "2022-05-13T06:18:32Z"
    }

commit time of the copy on proxy.golang.org

{"Version":"v1.2.1","Time":"2022-05-13T01:36:31Z"}

So the checksum from the code in github does not match the checksum saved in sum.golang.org. The v1.2.1 tag of github.com/argoproj/argo-rollouts might have been retagged after a minor edition on github. I guess you use proxy.golang.org to get dependencies, but that also shows that your project is depending on the copy of github.com/argoproj/[email protected] before its edition. Depending upon such inconsistent tag version may also result in some unexpected errors as well as build errors due to different proxy settings.

For example, when someone who does not use proxy.golang.org, say GOPROXY=direct, attempts to get github.com/argoproj/[email protected], the following error occurs.

go: downloading github.com/argoproj/argo-rollouts v1.2.1
go: github.com/argoproj/argo-rollouts@v1.2.1: verifying module: checksum mismatch
        downloaded: h1:8txnRKukYXvWMlLRQ4biixj9FdrLEGECyrW2eFsLTyc=
        sum.golang.org: h1:4hSgKEqpQsZreZBv+XcLsB+oBaRGMVW19nMScx5ikIQ=

SECURITY ERROR
This download does NOT match the one reported by the checksum server.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

So, this is a reminder in the hope that you can get rid of this problematic version of project github.com/argoproj/argo-rollouts.

Solution

1. Bump the version of dependency github.com/argoproj/argo-rollouts

I would recommend bumping the version of github.com/argoproj/argo-rollouts to a new release to ensure dependency copy in proxy.golang.org and github in sync.

References

• https://proxy.golang.org/

[aattuluri]

@Ben131-Go Thanks for the issue and all the details. Can you contribute the fix as well?

[nirvanagit]

@Ben131-Go : can you please validate with the current master?