From c487e7b5abfafeaad1b43d493d261af47fcde19e Mon Sep 17 00:00:00 2001
From: NaturezzZ <naturezzz@outlook.com>
Date: Thu, 15 Feb 2024 15:52:25 +0800
Subject: [PATCH 1/2] Add note on DR workloadSelector

---
 networking/v1alpha3/destination_rule.pb.go   | 6 ++++++
 networking/v1alpha3/destination_rule.pb.html | 5 +++++
 networking/v1alpha3/destination_rule.proto   | 6 ++++++
 3 files changed, 17 insertions(+)

diff --git a/networking/v1alpha3/destination_rule.pb.go b/networking/v1alpha3/destination_rule.pb.go
index 9a876940a7..bad2e2c19c 100644
--- a/networking/v1alpha3/destination_rule.pb.go
+++ b/networking/v1alpha3/destination_rule.pb.go
@@ -167,6 +167,12 @@
 // The following example shows how a destination rule can be applied to a
 // specific workload using the workloadSelector configuration.
 //
+// **Note:** The workloadSelector configuration in
+// Destination Rules reveals which workloads the traffic emanating from
+// uses this Destination Rule, unlike the workloadSelector configuration
+// in [ServiceEntries](https://istio.io/docs/reference/config/networking/service-entry/#ServiceEntry),
+// which is used to reveal which workloads the traffic is routed to.
+//
 // {{<tabset category-name="selector-example">}}
 // {{<tab name="v1alpha3" category-value="v1alpha3">}}
 // ```yaml
diff --git a/networking/v1alpha3/destination_rule.pb.html b/networking/v1alpha3/destination_rule.pb.html
index cc1a385a89..70820ec134 100644
--- a/networking/v1alpha3/destination_rule.pb.html
+++ b/networking/v1alpha3/destination_rule.pb.html
@@ -134,6 +134,11 @@
 <p>Destination Rules can be customized to specific workloads as well.
 The following example shows how a destination rule can be applied to a
 specific workload using the workloadSelector configuration.</p>
+<p><strong>Note:</strong> The workloadSelector configuration in
+Destination Rules reveals which workloads the traffic emanating from
+uses this Destination Rule, unlike the workloadSelector configuration
+in <a href="https://istio.io/docs/reference/config/networking/service-entry/#ServiceEntry">ServiceEntries</a>,
+which is used to reveal which workloads the traffic is routed to.</p>
 <p>{{<tabset category-name="selector-example">}}
 {{<tab name="v1alpha3" category-value="v1alpha3">}}</p>
 <pre><code class="language-yaml">apiVersion: networking.istio.io/v1alpha3
diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto
index ee2434cd17..fda65c0077 100644
--- a/networking/v1alpha3/destination_rule.proto
+++ b/networking/v1alpha3/destination_rule.proto
@@ -168,6 +168,12 @@ import "type/v1beta1/selector.proto";
 // The following example shows how a destination rule can be applied to a
 // specific workload using the workloadSelector configuration.
 //
+// **Note:** The workloadSelector configuration in 
+// Destination Rules reveals which workloads the traffic emanating from 
+// uses this Destination Rule, unlike the workloadSelector configuration 
+// in [ServiceEntries](https://istio.io/docs/reference/config/networking/service-entry/#ServiceEntry), 
+// which is used to reveal which workloads the traffic is routed to.
+// 
 // {{<tabset category-name="selector-example">}}
 // {{<tab name="v1alpha3" category-value="v1alpha3">}}
 // ```yaml

From 5dae24c0d74b6efea3d412f0626ae0d2d210b372 Mon Sep 17 00:00:00 2001
From: NaturezzZ <naturezzz@outlook.com>
Date: Sat, 17 Feb 2024 13:51:21 +0800
Subject: [PATCH 2/2] polish and remove comparison with SE

---
 networking/v1alpha3/destination_rule.pb.go   | 8 ++++----
 networking/v1alpha3/destination_rule.pb.html | 8 ++++----
 networking/v1alpha3/destination_rule.proto   | 8 ++++----
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/networking/v1alpha3/destination_rule.pb.go b/networking/v1alpha3/destination_rule.pb.go
index bad2e2c19c..c9f310ef4f 100644
--- a/networking/v1alpha3/destination_rule.pb.go
+++ b/networking/v1alpha3/destination_rule.pb.go
@@ -168,10 +168,10 @@
 // specific workload using the workloadSelector configuration.
 //
 // **Note:** The workloadSelector configuration in
-// Destination Rules reveals which workloads the traffic emanating from
-// uses this Destination Rule, unlike the workloadSelector configuration
-// in [ServiceEntries](https://istio.io/docs/reference/config/networking/service-entry/#ServiceEntry),
-// which is used to reveal which workloads the traffic is routed to.
+// destination rule controls which client workloads
+// use this destination rule, rather than which server workloads do.
+// [Subsets](https://istio.io/latest/docs/reference/config/networking/destination-rule/#Subset)
+// can be used to select server workloads in fine granularity.
 //
 // {{<tabset category-name="selector-example">}}
 // {{<tab name="v1alpha3" category-value="v1alpha3">}}
diff --git a/networking/v1alpha3/destination_rule.pb.html b/networking/v1alpha3/destination_rule.pb.html
index 70820ec134..465f68633b 100644
--- a/networking/v1alpha3/destination_rule.pb.html
+++ b/networking/v1alpha3/destination_rule.pb.html
@@ -135,10 +135,10 @@
 The following example shows how a destination rule can be applied to a
 specific workload using the workloadSelector configuration.</p>
 <p><strong>Note:</strong> The workloadSelector configuration in
-Destination Rules reveals which workloads the traffic emanating from
-uses this Destination Rule, unlike the workloadSelector configuration
-in <a href="https://istio.io/docs/reference/config/networking/service-entry/#ServiceEntry">ServiceEntries</a>,
-which is used to reveal which workloads the traffic is routed to.</p>
+destination rule controls which client workloads
+use this destination rule, rather than which server workloads do.
+<a href="https://istio.io/latest/docs/reference/config/networking/destination-rule/#Subset">Subsets</a>
+can be used to select server workloads in fine granularity.</p>
 <p>{{<tabset category-name="selector-example">}}
 {{<tab name="v1alpha3" category-value="v1alpha3">}}</p>
 <pre><code class="language-yaml">apiVersion: networking.istio.io/v1alpha3
diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto
index fda65c0077..dbe55a1848 100644
--- a/networking/v1alpha3/destination_rule.proto
+++ b/networking/v1alpha3/destination_rule.proto
@@ -169,10 +169,10 @@ import "type/v1beta1/selector.proto";
 // specific workload using the workloadSelector configuration.
 //
 // **Note:** The workloadSelector configuration in 
-// Destination Rules reveals which workloads the traffic emanating from 
-// uses this Destination Rule, unlike the workloadSelector configuration 
-// in [ServiceEntries](https://istio.io/docs/reference/config/networking/service-entry/#ServiceEntry), 
-// which is used to reveal which workloads the traffic is routed to.
+// destination rule controls which client workloads 
+// use this destination rule, rather than which server workloads do.
+// [Subsets](https://istio.io/latest/docs/reference/config/networking/destination-rule/#Subset) 
+// can be used to select server workloads in fine granularity.
 // 
 // {{<tabset category-name="selector-example">}}
 // {{<tab name="v1alpha3" category-value="v1alpha3">}}