Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problema con customer / prodotti disattivati #12

Open
primisuimotori opened this issue Oct 6, 2018 · 3 comments
Open

Problema con customer / prodotti disattivati #12

primisuimotori opened this issue Oct 6, 2018 · 3 comments

Comments

@primisuimotori
Copy link

primisuimotori commented Oct 6, 2018

Salve,

quando elimino o disattivo un prodotto che e' stato messo in un carrello da un customer ed il customer si ricollega, il sistema si blocca. Disattivando il vostro modulo tutto torna a funzionare. Vi è gia' successo ?

@paradoxos
Copy link

Salve,

quando elimino o disattivo un prodotto che e' stato messo in un carrello da un customer ed il customer si ricollega, il sistema si blocca. Disattivando il vostro modulo tutto torna a funzionare. Vi è gia' successo ?

Translated
Hello,
when I delete or deactivate a product that has been placed in a cart by a customer and the customer reconnects, the system freezes. Turning off your module everything works again. Has it happened before?

Hi we are experiencing the same issue. Our e-shop freezes even on login or customer save.

After days of debugging we found out that the problem occurs from this module.
!!! There is a loop. !!!

@ionpan
Copy link

ionpan commented Dec 4, 2019

It seems the problem occurs when \MSP\CashOnDelivery\Model\Total\Quote\AbstractTotal::_canApplyTotal() fetches the quote once again using $this->paymentMethodManagement->getList($quote->getId()). This method fetches the whole quote again (using \Magento\Quote\Model\Quote::loadByIdWithoutStore() instead of \Magento\Quote\Model\Quote::loadByCustomer() that was used on customer save) entering an infinite loop.

@ionpan
Copy link

ionpan commented Dec 4, 2019

A possible fix would be to add \Magento\Payment\Model\MethodList $methodList to the constructor of \MSP\CashOnDelivery\Model\Total\Quote\AbstractTotal and fetch the available methods using $this->methodList->getAvailableMethods($quote).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants